Skip to content

Convert ReactErrorBoundaries-test.internal.js to createRoot #28122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 3, 2024
Merged

Convert ReactErrorBoundaries-test.internal.js to createRoot #28122

merged 10 commits into from
Feb 3, 2024
+980 −602

Conversation

@mattcarrollcode
Copy link
Contributor

@mattcarrollcode mattcarrollcode commented Jan 27, 2024

No description provided.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 27, 2024
@react-sizebot
Copy link

react-sizebot commented Jan 27, 2024 •
edited
Loading

Comparing: d29f7d9...9704f0b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.57 kB 176.57 kB = 55.00 kB 55.00 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 178.69 kB 178.69 kB = 55.64 kB 55.64 kB
facebook-www/ReactDOM-prod.classic.js = 591.32 kB 591.32 kB = 104.34 kB 104.34 kB
facebook-www/ReactDOM-prod.modern.js = 575.08 kB 575.08 kB = 101.43 kB 101.43 kB
test_utils/ReactAllWarnings.js Deleted 67.56 kB 0.00 kB Deleted 16.59 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 67.56 kB 0.00 kB Deleted 16.59 kB 0.00 kB

Generated by 🚫 dangerJS against 9704f0b

@mattcarrollcode mattcarrollcode marked this pull request as ready for review January 30, 2024 19:29
rickhanlonii
rickhanlonii reviewed Feb 1, 2024
View reviewed changes
@mattcarrollcode mattcarrollcode merged commit 3d6fcf9 into facebook:main Feb 3, 2024
@gnoff gnoff mentioned this pull request Feb 5, 2024
Merged
@ztanner ztanner mentioned this pull request Mar 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickhanlonii rickhanlonii rickhanlonii approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mattcarrollcode @react-sizebot @rickhanlonii @facebook-github-bot