Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert ReactBrowserEventEmitter to createRoot #28253

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Convert ReactBrowserEventEmitter to createRoot #28253

merged 4 commits into from
Feb 6, 2024

Conversation

rickhanlonii
Copy link
Member

pretty boring

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 6, 2024
@react-sizebot
Copy link

react-sizebot commented Feb 6, 2024 •
edited
Loading

Comparing: 95ec128...d3a81b3

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.57 kB 176.57 kB = 55.00 kB 55.00 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 178.69 kB 178.69 kB = 55.64 kB 55.64 kB
facebook-www/ReactDOM-prod.classic.js = 591.32 kB 591.32 kB = 104.34 kB 104.34 kB
facebook-www/ReactDOM-prod.modern.js = 575.08 kB 575.08 kB = 101.43 kB 101.43 kB
test_utils/ReactAllWarnings.js Deleted 67.56 kB 0.00 kB Deleted 16.59 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 67.56 kB 0.00 kB Deleted 16.59 kB 0.00 kB

Generated by 🚫 dangerJS against d3a81b3

@rickhanlonii rickhanlonii merged commit 5446b09 into facebook:main Feb 6, 2024
36 checks passed
@rickhanlonii rickhanlonii deleted the rh/tests-rbee branch February 6, 2024 15:43
@ztanner ztanner mentioned this pull request Feb 9, 2024
Merged
huozhi pushed a commit to vercel/next.js that referenced this pull request Feb 9, 2024
@ztanner
Update React from 2bc7d336a to ba5e6a832 (#61837)
f165514 
Updates React from 2bc7d336a to ba5e6a832.

### React upstream changes

- facebook/react#28283
- facebook/react#28280
- facebook/react#28079
- facebook/react#28233
- facebook/react#28276
- facebook/react#28272
- facebook/react#28265
- facebook/react#28259
- facebook/react#28153
- facebook/react#28246
- facebook/react#28218
- facebook/react#28263
- facebook/react#28257
- facebook/react#28261
- facebook/react#28262
- facebook/react#28260
- facebook/react#28258
- facebook/react#27864
- facebook/react#28254
- facebook/react#28219
- facebook/react#28248
- facebook/react#28216
- facebook/react#28249
- facebook/react#28241
- facebook/react#28243
- facebook/react#28253
- facebook/react#28256
- facebook/react#28236
- facebook/react#28237
- facebook/react#28242
- facebook/react#28251
- facebook/react#28252

Closes NEXT-2411
@ztanner ztanner mentioned this pull request Mar 19, 2024
Closed
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@rickhanlonii @AndyPengc12
Convert ReactBrowserEventEmitter to createRoot (facebook#28253)
b865efb 
pretty boring
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@rickhanlonii
Convert ReactBrowserEventEmitter to createRoot (#28253)
7241731 
pretty boring

DiffTrain build for commit 5446b09.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoxyq hoxyq hoxyq approved these changes

@kassens kassens kassens approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rickhanlonii @react-sizebot @kassens @hoxyq @facebook-github-bot