[RN] Use microtasks in the RN renderer based on a global flag defined by RN #28472

rubennorte · 2024-02-29T14:49:10Z

Summary

We want to enable the new event loop in React Native (react-native-community/discussions-and-proposals#744) for all users in the new architecture (determined by the use of bridgeless, not by the use of Fabric). In order to leverage that, we need to also set the flag for the React reconciler to use microtasks for scheduling (so we'll execute them at the right time in the new event loop).

This migrates from the previous approach using a dynamic flag (to be used at Meta) with the check of a global set by React Native. The reason for doing this is:

We still need to determine this dynamically in OSS (based on Bridgeless, not on Fabric).
We still need the ability to configure the behavior at Meta, and for internal build system reasons we cannot access the flag that enables microtasks in ReactNativeFeatureFlags.

How did you test this change?

Manually synchronized the changes to React Native and ran all tests for the new architecture on it. Also tested manually.

Note

This change depends on facebook/react-native#43397 which has been merged already

react-sizebot · 2024-02-29T14:53:31Z

Comparing: dfaed55...90c9589

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	177.10 kB	177.10 kB	=	55.20 kB	55.20 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	177.64 kB	177.64 kB	=	55.53 kB	55.53 kB
facebook-www/ReactDOM-prod.classic.js	=	594.34 kB	594.34 kB	=	104.96 kB	104.96 kB
facebook-www/ReactDOM-prod.modern.js	=	577.60 kB	577.60 kB	=	102.02 kB	102.02 kB
test_utils/ReactAllWarnings.js	Deleted	66.60 kB	0.00 kB	Deleted	16.28 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	66.60 kB	0.00 kB	Deleted	16.28 kB	0.00 kB

Generated by 🚫 dangerJS against 90c9589

packages/shared/forks/ReactFeatureFlags.native-oss.js

scripts/flow/xplat.js

.eslintrc.js

rickhanlonii

LGTM

… renderer (OSS version)

… by RN (facebook#28472) ## Summary We want to enable the new event loop in React Native (react-native-community/discussions-and-proposals#744) for all users in the new architecture (determined by the use of bridgeless, not by the use of Fabric). In order to leverage that, we need to also set the flag for the React reconciler to use microtasks for scheduling (so we'll execute them at the right time in the new event loop). This migrates from the previous approach using a dynamic flag (to be used at Meta) with the check of a global set by React Native. The reason for doing this is: 1) We still need to determine this dynamically in OSS (based on Bridgeless, not on Fabric). 2) We still need the ability to configure the behavior at Meta, and for internal build system reasons we cannot access the flag that enables microtasks in [`ReactNativeFeatureFlags`](https://github.com/facebook/react-native/blob/6c28c87c4d5d8a9f5be5e02cd7d3eba5b4aaca8c/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js#L121). ## How did you test this change? Manually synchronized the changes to React Native and ran all tests for the new architecture on it. Also tested manually. > [!NOTE] > This change depends on facebook/react-native#43397 which has been merged already

… by RN (#28472) ## Summary We want to enable the new event loop in React Native (react-native-community/discussions-and-proposals#744) for all users in the new architecture (determined by the use of bridgeless, not by the use of Fabric). In order to leverage that, we need to also set the flag for the React reconciler to use microtasks for scheduling (so we'll execute them at the right time in the new event loop). This migrates from the previous approach using a dynamic flag (to be used at Meta) with the check of a global set by React Native. The reason for doing this is: 1) We still need to determine this dynamically in OSS (based on Bridgeless, not on Fabric). 2) We still need the ability to configure the behavior at Meta, and for internal build system reasons we cannot access the flag that enables microtasks in [`ReactNativeFeatureFlags`](https://github.com/facebook/react-native/blob/6c28c87c4d5d8a9f5be5e02cd7d3eba5b4aaca8c/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js#L121). ## How did you test this change? Manually synchronized the changes to React Native and ran all tests for the new architecture on it. Also tested manually. > [!NOTE] > This change depends on facebook/react-native#43397 which has been merged already DiffTrain build for commit bb0944f.

facebook-github-bot added the CLA Signed label Feb 29, 2024

rubennorte force-pushed the use-microtasks-in-react-native-bridgeless-mode branch 2 times, most recently from 28e6d89 to a64f1fc Compare February 29, 2024 17:38

rickhanlonii reviewed Mar 1, 2024

View reviewed changes

packages/shared/forks/ReactFeatureFlags.native-oss.js Show resolved Hide resolved

rickhanlonii reviewed Mar 1, 2024

View reviewed changes

scripts/flow/xplat.js Outdated Show resolved Hide resolved

rickhanlonii reviewed Mar 1, 2024

View reviewed changes

.eslintrc.js Outdated Show resolved Hide resolved

rubennorte force-pushed the use-microtasks-in-react-native-bridgeless-mode branch from a64f1fc to c2578a3 Compare March 1, 2024 14:37

rubennorte force-pushed the use-microtasks-in-react-native-bridgeless-mode branch from c2578a3 to 52e7313 Compare March 8, 2024 15:59

rubennorte marked this pull request as ready for review March 8, 2024 16:01

rubennorte requested review from javache, sammy-SC and cortinico March 8, 2024 16:13

rubennorte force-pushed the use-microtasks-in-react-native-bridgeless-mode branch from 52e7313 to 6e0301b Compare March 8, 2024 20:35

rubennorte changed the title ~~[RN] Use microtasks when using bridgeless mode in React Native Fabric renderer (OSS version)~~ [RN] Use microtasks in the RN renderer based on a global flag defined by RN Mar 8, 2024

rubennorte requested a review from rickhanlonii March 8, 2024 20:41

rickhanlonii approved these changes Mar 8, 2024

View reviewed changes

[RN] Use microtasks when using bridgeless mode in React Native Fabric…

90c9589

… renderer (OSS version)

rubennorte force-pushed the use-microtasks-in-react-native-bridgeless-mode branch from 6e0301b to 90c9589 Compare March 11, 2024 13:54

rubennorte merged commit bb0944f into facebook:main Mar 13, 2024
38 checks passed

rubennorte deleted the use-microtasks-in-react-native-bridgeless-mode branch March 13, 2024 13:30

ztanner mentioned this pull request Mar 18, 2024

Update React from 6c3b8dbfe to a4939017f vercel/next.js#63413

Closed

gnoff mentioned this pull request Mar 25, 2024

Update React from 14898b6a9 to e373190fa vercel/next.js#63685

Closed

ztanner mentioned this pull request Apr 2, 2024

Update React from 14898b6a9 to a870b2d54 vercel/next.js#63976

Closed

eps1lon mentioned this pull request Apr 19, 2024

Update React from 14898b6a9 to c3048aab4 vercel/next.js#64798

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RN] Use microtasks in the RN renderer based on a global flag defined by RN #28472

[RN] Use microtasks in the RN renderer based on a global flag defined by RN #28472

rubennorte commented Feb 29, 2024 •

edited

Loading

react-sizebot commented Feb 29, 2024 •

edited

Loading

rickhanlonii left a comment

[RN] Use microtasks in the RN renderer based on a global flag defined by RN #28472

[RN] Use microtasks in the RN renderer based on a global flag defined by RN #28472

Conversation

rubennorte commented Feb 29, 2024 • edited Loading

Summary

How did you test this change?

react-sizebot commented Feb 29, 2024 • edited Loading

Critical size changes

Significant size changes

rickhanlonii left a comment

Choose a reason for hiding this comment

rubennorte commented Feb 29, 2024 •

edited

Loading

react-sizebot commented Feb 29, 2024 •

edited

Loading