Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove excess ms prop from Suspense tests #28566

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Remove excess ms prop from Suspense tests #28566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions packages/react-reconciler/src/__tests__/ReactSuspense-test.internal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ describe('ReactSuspense', () => {
<Suspense fallback={<Text text="Loading..." />}>
{renderBar ? (
<Bar>
<AsyncText text="A" ms={100} />
<AsyncText text="A" />
<Text text="B" />
</Bar>
) : null}
Expand Down Expand Up @@ -153,10 +153,10 @@ describe('ReactSuspense', () => {
root.render(
<>
<Suspense fallback={<Text text="Loading A..." />}>
<AsyncText text="A" ms={5000} />
<AsyncText text="A" />
</Suspense>
<Suspense fallback={<Text text="Loading B..." />}>
<AsyncText text="B" ms={6000} />
<AsyncText text="B" />
</Suspense>
</>,
);
Expand Down Expand Up @@ -258,9 +258,9 @@ describe('ReactSuspense', () => {
Scheduler.log('Foo');
return (
<Suspense fallback={<Text text="Loading..." />}>
<AsyncText text="A" ms={200} />
<AsyncText text="A" />
<Suspense fallback={<Text text="Loading more..." />}>
<AsyncText text="B" ms={300} />
<AsyncText text="B" />
</Suspense>
</Suspense>
);
Expand Down Expand Up @@ -294,9 +294,9 @@ describe('ReactSuspense', () => {
Scheduler.log('Foo');
return (
<Suspense fallback={<Text text="Loading..." />}>
<AsyncText text="A" ms={200} />
<AsyncText text="A" />
<Suspense fallback={<Text text="Loading more..." />}>
<AsyncText text="B" ms={1200} />
<AsyncText text="B" />
</Suspense>
</Suspense>
);
Expand Down Expand Up @@ -346,7 +346,7 @@ describe('ReactSuspense', () => {
<>
<Text text={`A${step}`} />
<Suspense fallback={<Text text="Loading..." />}>
{shouldSuspend ? <AsyncText text="Async" ms={2000} /> : null}
{shouldSuspend ? <AsyncText text="Async" /> : null}
</Suspense>
<Text text={`B${step}`} />
<Text text={`C${step}`} />
Expand Down Expand Up @@ -627,7 +627,7 @@ describe('ReactSuspense', () => {
return (
<Suspense fallback={<Text text="Loading..." />}>
<TextWithLayout text="Child 1" />
{show && <AsyncText ms={1000} text="Child 2" />}
{show && <AsyncText text="Child 2" />}
</Suspense>
);
}
Expand Down Expand Up @@ -722,7 +722,7 @@ describe('ReactSuspense', () => {
return (
<Suspense fallback={<TextWithLifecycle text="Loading..." />}>
<TextWithLifecycle text="A" />
<AsyncTextWithLifecycle ms={100} text="B" ref={instance} />
<AsyncTextWithLifecycle text="B" ref={instance} />
<TextWithLifecycle text="C" />
</Suspense>
);
Expand Down Expand Up @@ -776,7 +776,7 @@ describe('ReactSuspense', () => {
return (
<Suspense fallback={<Text text="Loading..." />}>
<Stateful />
<AsyncText ms={1000} text={props.text} />
<AsyncText text={props.text} />
</Suspense>
);
}
Expand Down Expand Up @@ -822,7 +822,7 @@ describe('ReactSuspense', () => {
<Indirection>
<Indirection>
<Indirection>
<AsyncText ms={1000} text={props.text} />
<AsyncText text={props.text} />
</Indirection>
</Indirection>
</Indirection>
Expand Down Expand Up @@ -872,7 +872,7 @@ describe('ReactSuspense', () => {
function App({text}) {
return (
<Suspense fallback={<Text text="Loading..." />}>
<AsyncTextWithUnmount text={text} ms={100} />
<AsyncTextWithUnmount text={text} />
</Suspense>
);
}
Expand Down Expand Up @@ -902,7 +902,7 @@ describe('ReactSuspense', () => {
function App({text}) {
return (
<Suspense fallback={<Text text="Loading..." />}>
<AsyncTextWithEffect text={text} ms={100} />
<AsyncTextWithEffect text={text} />
</Suspense>
);
}
Expand All @@ -920,7 +920,7 @@ describe('ReactSuspense', () => {
state = {step: 1};
render() {
instance = this;
return <AsyncText ms={1000} text={`Step: ${this.state.step}`} />;
return <AsyncText text={`Step: ${this.state.step}`} />;
}
}

Expand Down Expand Up @@ -976,9 +976,9 @@ describe('ReactSuspense', () => {
function App(props) {
return (
<Suspense fallback={<ShouldMountOnce />}>
<AsyncText ms={1000} text="Child 1" />
<AsyncText ms={2000} text="Child 2" />
<AsyncText ms={3000} text="Child 3" />
<AsyncText text="Child 1" />
<AsyncText text="Child 2" />
<AsyncText text="Child 3" />
</Suspense>
);
}
Expand Down Expand Up @@ -1019,7 +1019,7 @@ describe('ReactSuspense', () => {

return (
<Suspense fallback={<Text text="Loading..." />}>
<AsyncText key={tab} text={'Tab: ' + tab} ms={1000} />
<AsyncText key={tab} text={'Tab: ' + tab} />
<Text key={tab + 'sibling'} text=" + sibling" />
</Suspense>
);
Expand Down Expand Up @@ -1087,9 +1087,9 @@ describe('ReactSuspense', () => {
function App() {
return (
<Suspense fallback={<Text text="Loading..." />}>
<AsyncText text="A" ms={1000} />
<AsyncText text="B" ms={2000} />
<AsyncText text="C" ms={3000} />
<AsyncText text="A" />
<AsyncText text="B" />
<AsyncText text="C" />
</Suspense>
);
}
Expand Down
Loading