Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gating for alwaysThrottleDisappearingFallbacks #28629

Closed
wants to merge 1 commit into from
+8 −1
Closed

Fix gating for alwaysThrottleDisappearingFallbacks #28629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/react-reconciler/src/__tests__/ReactSuspenseWithNoopRenderer-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1846,7 +1846,14 @@ describe('ReactSuspenseWithNoopRenderer', () => {
await resolveText('B');
await waitForPaint(['B']);

if (gate(flags => flags.alwaysThrottleRetries)) {
if (
// This behavior only applies if both flags are enabled.
gate(
flags =>
flags.alwaysThrottleDisappearingFallbacks &&
flags.alwaysThrottleRetries,
)
) {
// B should not commit yet. Even though it's been a long time since its
// fallback was shown, it hasn't been long since A appeared. So B's
// appearance is throttled to reduce jank.
Expand Down