Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @providesModule remnants #28720

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Remove @providesModule remnants #28720

merged 1 commit into from
Apr 3, 2024

Conversation

kassens
Copy link
Member

@kassens kassens commented Apr 2, 2024

Remove @providesModule remnants

Removes @providesModule from the generated RN modules and CI validation that no @providesModule is added which should no longer be needed as this has been the case for years now.

Removes `@providesModule` from the generated RN modules and CI validation that no `@providesModule` is added which should no longer be needed as this has been the case for years now.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 2, 2024
@kassens kassens requested a review from yungsters April 2, 2024 17:53
@react-sizebot
Copy link

Comparing: ba5496d...fe7ebfb

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.97 kB 176.97 kB = 55.00 kB 55.00 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 172.83 kB 172.83 kB = 53.88 kB 53.88 kB
facebook-www/ReactDOM-prod.classic.js = 591.26 kB 591.26 kB = 103.73 kB 103.73 kB
facebook-www/ReactDOM-prod.modern.js = 573.00 kB 573.00 kB = 100.79 kB 100.79 kB
test_utils/ReactAllWarnings.js Deleted 64.93 kB 0.00 kB Deleted 16.24 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.93 kB 0.00 kB Deleted 16.24 kB 0.00 kB

Generated by 🚫 dangerJS against fe7ebfb

@kassens kassens requested review from rubennorte and jackpope April 2, 2024 22:49
@kassens kassens merged commit 4e8121a into facebook:main Apr 3, 2024
38 checks passed
@kassens kassens deleted the pr28720 branch April 3, 2024 13:10
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Remove @providesModule remnants

Removes `@providesModule` from the generated RN modules and CI
validation that no `@providesModule` is added which should no longer be
needed as this has been the case for years now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants