Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOM] Shrink ReactDOMSharedInternals source representation #28771

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Apr 5, 2024

Stacked on #28751

ReactDOMSharedInternals uses properties of considerable length to model mutuable state. These properties are not mangled during minification and contribute a not insigificant amount to the uncompressed bundle size and to a lesser degree compressed bundle size.

This change rewrites the DOMInternals in a way that shortens property names so we can have smaller builds.
It also treats the entire object as a mutable container rather than having different mutable sub objects.

The same treatment should be given to ReactSharedInternals

@react-sizebot
Copy link

react-sizebot commented Apr 5, 2024

Comparing: 01bb3c5...2cdb7c0

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 169.11 kB 168.79 kB = 52.76 kB 52.65 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 170.91 kB 170.59 kB = 53.27 kB 53.18 kB
facebook-www/ReactDOM-prod.classic.js = 590.58 kB 590.06 kB = 103.86 kB 103.78 kB
facebook-www/ReactDOM-prod.modern.js = 566.68 kB 566.07 kB = 100.01 kB 99.93 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.production.min.js = 3.90 kB 3.77 kB = 1.42 kB 1.39 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.production.min.js = 3.89 kB 3.76 kB = 1.42 kB 1.39 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.production.min.js = 3.87 kB 3.73 kB = 1.39 kB 1.37 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.production.min.js = 3.76 kB 3.63 kB = 1.32 kB 1.30 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.production.min.js = 3.76 kB 3.62 kB = 1.33 kB 1.30 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.production.min.js = 3.73 kB 3.60 kB = 1.30 kB 1.28 kB
oss-experimental/react-dom/cjs/react-dom.react-server.production.min.js = 2.77 kB 2.64 kB = 0.91 kB 0.87 kB
oss-stable-semver/react-dom/cjs/react-dom.react-server.production.min.js = 2.77 kB 2.64 kB = 0.91 kB 0.87 kB
oss-stable/react-dom/cjs/react-dom.react-server.production.min.js = 2.77 kB 2.64 kB = 0.91 kB 0.87 kB
test_utils/ReactAllWarnings.js Deleted 64.04 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-dom/cjs/react-dom.react-server.production.js +1.79% 6.76 kB 6.88 kB +0.35% 1.43 kB 1.43 kB
oss-stable-semver/react-dom/cjs/react-dom.react-server.production.js +1.79% 6.76 kB 6.88 kB +0.35% 1.43 kB 1.43 kB
oss-stable/react-dom/cjs/react-dom.react-server.production.js +1.79% 6.76 kB 6.88 kB +0.35% 1.43 kB 1.43 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.production.js +1.27% 9.54 kB 9.66 kB +0.29% 2.44 kB 2.44 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.production.js +1.27% 9.56 kB 9.68 kB +0.12% 2.47 kB 2.47 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.production.js +1.26% 9.57 kB 9.69 kB +0.12% 2.47 kB 2.47 kB
oss-experimental/react-dom/cjs/react-dom.react-server.development.js +0.81% 14.99 kB 15.12 kB +0.16% 3.21 kB 3.21 kB
oss-stable-semver/react-dom/cjs/react-dom.react-server.development.js +0.81% 14.99 kB 15.12 kB +0.16% 3.21 kB 3.21 kB
oss-stable/react-dom/cjs/react-dom.react-server.development.js +0.81% 14.99 kB 15.12 kB +0.16% 3.21 kB 3.21 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.development.js +0.80% 19.14 kB 19.29 kB +0.18% 4.38 kB 4.39 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.development.js +0.80% 19.16 kB 19.32 kB +0.11% 4.41 kB 4.42 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.development.js +0.80% 19.17 kB 19.32 kB +0.09% 4.41 kB 4.41 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.development.js +0.67% 18.20 kB 18.33 kB +0.16% 4.26 kB 4.26 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.development.js +0.67% 18.23 kB 18.35 kB +0.14% 4.28 kB 4.29 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.development.js +0.67% 18.24 kB 18.36 kB +0.12% 4.28 kB 4.29 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.min.js = 14.29 kB 14.26 kB = 5.15 kB 5.11 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.min.js = 14.29 kB 14.26 kB = 5.15 kB 5.11 kB
facebook-www/ReactFlightDOMClient-prod.modern.js = 20.16 kB 20.11 kB = 4.82 kB 4.82 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-client.browser.production.min.js = 14.54 kB 14.51 kB = 5.24 kB 5.22 kB
oss-experimental/react-server-dom-turbopack/umd/react-server-dom-turbopack-client.browser.production.min.js = 14.42 kB 14.38 kB = 5.20 kB 5.19 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.min.js = 14.35 kB 14.32 kB = 5.14 kB 5.12 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.min.js = 14.23 kB 14.20 kB = 5.11 kB 5.09 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.min.js = 13.56 kB 13.53 kB = 4.84 kB 4.82 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-client.browser.production.min.js = 13.16 kB 13.13 kB = 4.87 kB 4.86 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-client.browser.production.min.js = 13.16 kB 13.13 kB = 4.87 kB 4.86 kB
oss-stable-semver/react-server-dom-turbopack/umd/react-server-dom-turbopack-client.browser.production.min.js = 13.04 kB 13.00 kB = 4.84 kB 4.82 kB
oss-stable/react-server-dom-turbopack/umd/react-server-dom-turbopack-client.browser.production.min.js = 13.04 kB 13.00 kB = 4.84 kB 4.82 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.min.js = 12.97 kB 12.94 kB = 4.77 kB 4.75 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.min.js = 12.97 kB 12.94 kB = 4.77 kB 4.75 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.min.js = 12.85 kB 12.82 kB = 4.73 kB 4.71 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.min.js = 12.85 kB 12.82 kB = 4.73 kB 4.71 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.min.js = 12.18 kB 12.15 kB = 4.46 kB 4.44 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.min.js = 12.18 kB 12.15 kB = 4.46 kB 4.44 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.min.js = 16.84 kB 16.79 kB = 5.95 kB 5.93 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.min.js = 16.84 kB 16.79 kB = 5.94 kB 5.92 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.min.js = 16.40 kB 16.35 kB = 5.83 kB 5.81 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.min.js = 16.39 kB 16.34 kB = 5.82 kB 5.79 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.min.js = 16.08 kB 16.03 kB = 5.71 kB 5.69 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.min.js = 16.08 kB 16.03 kB = 5.71 kB 5.69 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.min.js = 15.46 kB 15.41 kB = 5.57 kB 5.55 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.min.js = 15.46 kB 15.41 kB = 5.57 kB 5.55 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.min.js = 15.45 kB 15.40 kB = 5.56 kB 5.54 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.min.js = 15.45 kB 15.40 kB = 5.56 kB 5.54 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.min.js = 15.01 kB 14.96 kB = 5.45 kB 5.42 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.min.js = 15.01 kB 14.96 kB = 5.45 kB 5.42 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.min.js = 15.00 kB 14.95 kB = 5.43 kB 5.41 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.min.js = 15.00 kB 14.95 kB = 5.43 kB 5.41 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.min.js = 14.69 kB 14.64 kB = 5.32 kB 5.30 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.min.js = 14.69 kB 14.64 kB = 5.32 kB 5.30 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.min.js = 14.69 kB 14.64 kB = 5.32 kB 5.30 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.min.js = 14.69 kB 14.64 kB = 5.32 kB 5.30 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.production.min.js = 3.90 kB 3.77 kB = 1.42 kB 1.39 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.production.min.js = 3.89 kB 3.76 kB = 1.42 kB 1.39 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.production.min.js = 3.87 kB 3.73 kB = 1.39 kB 1.37 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.production.min.js = 3.76 kB 3.63 kB = 1.32 kB 1.30 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.production.min.js = 3.76 kB 3.62 kB = 1.33 kB 1.30 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.production.min.js = 3.73 kB 3.60 kB = 1.30 kB 1.28 kB
oss-experimental/react-dom/cjs/react-dom.react-server.production.min.js = 2.77 kB 2.64 kB = 0.91 kB 0.87 kB
oss-stable-semver/react-dom/cjs/react-dom.react-server.production.min.js = 2.77 kB 2.64 kB = 0.91 kB 0.87 kB
oss-stable/react-dom/cjs/react-dom.react-server.production.min.js = 2.77 kB 2.64 kB = 0.91 kB 0.87 kB
test_utils/ReactAllWarnings.js Deleted 64.04 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against 2cdb7c0

@gnoff gnoff force-pushed the shrink-dom-internals branch 2 times, most recently from bd85e05 to cc3ce99 Compare April 5, 2024 21:48
@@ -173,7 +173,7 @@ export {

// Keep in sync with ReactTestUtils.js.
// This is an array for better minification.
Internals.Events = [
Internals.E /* Events */ = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this one is used by other things too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to FB only builds

@@ -95,7 +95,7 @@ function createRoot(
options?: CreateRootOptions,
): RootType {
if (__DEV__) {
if (!Internals.usingClientEntryPoint && !__UMD__) {
if (!Internals.c /* usingClientEntryPoint */ && !__UMD__) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DEV only ones are maybe not necessary.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to dev only internals (this is going to be removed before 19 anyway)

@gnoff gnoff force-pushed the shrink-dom-internals branch 2 times, most recently from 69f79f4 to fcc798c Compare April 8, 2024 16:52
@gnoff gnoff force-pushed the shrink-dom-internals branch 8 times, most recently from 706fa73 to 8895320 Compare April 8, 2024 20:25
@gnoff gnoff merged commit 9007fdc into facebook:main Apr 8, 2024
38 checks passed
@gnoff gnoff deleted the shrink-dom-internals branch April 8, 2024 20:39
github-actions bot pushed a commit that referenced this pull request Apr 8, 2024
Stacked on #28751

ReactDOMSharedInternals uses properties of considerable length to model
mutuable state. These properties are not mangled during minification and
contribute a not insigificant amount to the uncompressed bundle size and
to a lesser degree compressed bundle size.

This change rewrites the DOMInternals in a way that shortens property
names so we can have smaller builds.
It also treats the entire object as a mutable container rather than
having different mutable sub objects.

The same treatment should be given to ReactSharedInternals

DiffTrain build for [9007fdc](9007fdc)
gnoff added a commit that referenced this pull request Apr 8, 2024
Stacked on #28771 

ReactDOMCurrentDispatcher has longer property names for various methods.
These methods are only ever called internally and don't need to be
represented with as many characters. This change shortens the names and
aligns them with the hint codes we use in Flight. This alignment is
passive since not all dispatcher methods will exist as flight
instructions but where they can line up it seems reasonable to make them
do so
github-actions bot pushed a commit that referenced this pull request Apr 8, 2024
Stacked on #28771

ReactDOMCurrentDispatcher has longer property names for various methods.
These methods are only ever called internally and don't need to be
represented with as many characters. This change shortens the names and
aligns them with the hint codes we use in Flight. This alignment is
passive since not all dispatcher methods will exist as flight
instructions but where they can line up it seems reasonable to make them
do so

DiffTrain build for [97c90ed](97c90ed)
sebmarkbage added a commit that referenced this pull request Apr 8, 2024
This is similar to #28771 but for isomorphic. We need a make over for
these dispatchers anyway so this is the first step. Also helps flush out
some internals usage that will break anyway.

It flattens the inner mutable objects onto the ReactSharedInternals.
github-actions bot pushed a commit that referenced this pull request Apr 8, 2024
This is similar to #28771 but for isomorphic. We need a make over for
these dispatchers anyway so this is the first step. Also helps flush out
some internals usage that will break anyway.

It flattens the inner mutable objects onto the ReactSharedInternals.

DiffTrain build for [d50323e](d50323e)
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build size goes up in non-minified builds?

};

// if (__DEV__) {
// (Internals: any).usingClientEntryPoint = false;
// }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this commented out?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was sloppy. I can land removing it but I’ve also already removed it in the next change which moves around all the entry points.

rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
Stacked on #28751 

ReactDOMSharedInternals uses properties of considerable length to model
mutuable state. These properties are not mangled during minification and
contribute a not insigificant amount to the uncompressed bundle size and
to a lesser degree compressed bundle size.

This change rewrites the DOMInternals in a way that shortens property
names so we can have smaller builds.
It also treats the entire object as a mutable container rather than
having different mutable sub objects.

The same treatment should be given to ReactSharedInternals
rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
Stacked on #28771 

ReactDOMCurrentDispatcher has longer property names for various methods.
These methods are only ever called internally and don't need to be
represented with as many characters. This change shortens the names and
aligns them with the hint codes we use in Flight. This alignment is
passive since not all dispatcher methods will exist as flight
instructions but where they can line up it seems reasonable to make them
do so
rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
This is similar to #28771 but for isomorphic. We need a make over for
these dispatchers anyway so this is the first step. Also helps flush out
some internals usage that will break anyway.

It flattens the inner mutable objects onto the ReactSharedInternals.
rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
Stacked on #28751 

ReactDOMSharedInternals uses properties of considerable length to model
mutuable state. These properties are not mangled during minification and
contribute a not insigificant amount to the uncompressed bundle size and
to a lesser degree compressed bundle size.

This change rewrites the DOMInternals in a way that shortens property
names so we can have smaller builds.
It also treats the entire object as a mutable container rather than
having different mutable sub objects.

The same treatment should be given to ReactSharedInternals
rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
Stacked on #28771 

ReactDOMCurrentDispatcher has longer property names for various methods.
These methods are only ever called internally and don't need to be
represented with as many characters. This change shortens the names and
aligns them with the hint codes we use in Flight. This alignment is
passive since not all dispatcher methods will exist as flight
instructions but where they can line up it seems reasonable to make them
do so
rickhanlonii pushed a commit that referenced this pull request Apr 11, 2024
This is similar to #28771 but for isomorphic. We need a make over for
these dispatchers anyway so this is the first step. Also helps flush out
some internals usage that will break anyway.

It flattens the inner mutable objects onto the ReactSharedInternals.
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…28771)

Stacked on facebook#28751 

ReactDOMSharedInternals uses properties of considerable length to model
mutuable state. These properties are not mangled during minification and
contribute a not insigificant amount to the uncompressed bundle size and
to a lesser degree compressed bundle size.

This change rewrites the DOMInternals in a way that shortens property
names so we can have smaller builds.
It also treats the entire object as a mutable container rather than
having different mutable sub objects.

The same treatment should be given to ReactSharedInternals
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Stacked on facebook#28771 

ReactDOMCurrentDispatcher has longer property names for various methods.
These methods are only ever called internally and don't need to be
represented with as many characters. This change shortens the names and
aligns them with the hint codes we use in Flight. This alignment is
passive since not all dispatcher methods will exist as flight
instructions but where they can line up it seems reasonable to make them
do so
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
This is similar to facebook#28771 but for isomorphic. We need a make over for
these dispatchers anyway so this is the first step. Also helps flush out
some internals usage that will break anyway.

It flattens the inner mutable objects onto the ReactSharedInternals.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
This is similar to #28771 but for isomorphic. We need a make over for
these dispatchers anyway so this is the first step. Also helps flush out
some internals usage that will break anyway.

It flattens the inner mutable objects onto the ReactSharedInternals.

DiffTrain build for commit d50323e.
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Apr 19, 2024
Summary:
This sync includes the changes from:
- D56103750
- [TODO] A shim for SECRET_INTERNALS

This sync includes the following changes:
- **[b5e5ce8e0](facebook/react@b5e5ce8e0 )**: Update ReactNativeTypes for root options (part 2) ([#28857](facebook/react#28857)) //<Ricky>//
- **[da6ba53b1](facebook/react@da6ba53b1 )**: [UMD] Remove umd builds ([#28735](facebook/react#28735)) //<Josh Story>//
- **[0c245df1d](facebook/react@0c245df1d )**: Complete the typo fix ([#28856](facebook/react#28856)) //<Sebastian Silbermann>//
- **[f82051d7a](facebook/react@f82051d7a )**: console test utils fix: match entire string, not just first letter ([#28855](facebook/react#28855)) //<Andrew Clark>//
- **[4ca20fd36](facebook/react@4ca20fd36 )**: Test top level fragment inside lazy semantics ([#28852](facebook/react#28852)) //<Sebastian Markbåge>//
- **[c0cf7c696](facebook/react@c0cf7c696 )**: Promote ASYNC_ITERATOR symbol to React Symbols ([#28851](facebook/react#28851)) //<Sebastian Markbåge>//
- **[657428a9e](facebook/react@657428a9e )**: Add ReactNativeTypes for root options ([#28850](facebook/react#28850)) //<Ricky>//
- **[7909d8eab](facebook/react@7909d8eab )**: [Flight] Encode ReadableStream and AsyncIterables ([#28847](facebook/react#28847)) //<Sebastian Markbåge>//
- **[13eb61d05](facebook/react@13eb61d05 )**: Move enableUseDeferredValueInitialArg to canary ([#28818](facebook/react#28818)) //<Andrew Clark>//
- **[8afa144bd](facebook/react@8afa144bd )**: Enable flag disableClientCache ([#28846](facebook/react#28846)) //<Jan Kassens>//
- **[734956ace](facebook/react@734956ace )**: Devtools: Add support for useFormStatus ([#28413](facebook/react#28413)) //<Sebastian Silbermann>//
- **[17e920c00](facebook/react@17e920c00 )**: [Flight Reply] Encode Typed Arrays and Blobs ([#28819](facebook/react#28819)) //<Sebastian Markbåge>//
- **[0347fcd00](facebook/react@0347fcd00 )**: Add on(Caught|Uncaught|Recoverable) opts to RN ([#28836](facebook/react#28836)) //<Ricky>//
- **[c113503ad](facebook/react@c113503ad )**: Flush direct streams in Bun ([#28837](facebook/react#28837)) //<Kenta Iwasaki>//
- **[9defcd56b](facebook/react@9defcd56b )**: Remove redundant props assign ([#28829](facebook/react#28829)) //<Sebastian Silbermann>//
- **[ed4023603](facebook/react@ed4023603 )**: Fix mistaken "react-server" condition ([#28835](facebook/react#28835)) //<Sebastian Markbåge>//
- **[c8a035036](facebook/react@c8a035036 )**: [Fizz] hoistables should never flush before the preamble ([#28802](facebook/react#28802)) //<Josh Story>//
- **[4f5c812a3](facebook/react@4f5c812a3 )**: DevTools: Rely on sourcemaps to compute hook name of built-in hooks in newer versions ([#28593](facebook/react#28593)) //<Sebastian Silbermann>//
- **[435415962](facebook/react@435415962 )**: Backwards compatibility for string refs on WWW ([#28826](facebook/react#28826)) //<Jack Pope>//
- **[608edcc90](facebook/react@608edcc90 )**: [tests] add `assertConsole<method>Dev` helpers ([#28732](facebook/react#28732)) //<Ricky>//
- **[da69b6af9](facebook/react@da69b6af9 )**: ReactDOM.requestFormReset  ([#28809](facebook/react#28809)) //<Andrew Clark>//
- **[374b5d26c](facebook/react@374b5d26c )**: Scaffolding for requestFormReset API ([#28808](facebook/react#28808)) //<Andrew Clark>//
- **[41950d14a](facebook/react@41950d14a )**: Automatically reset forms after action finishes ([#28804](facebook/react#28804)) //<Andrew Clark>//
- **[dc6a7e01e](facebook/react@dc6a7e01e )**: [Float] Don't preload images inside `<noscript>` ([#28815](facebook/react#28815)) //<Josh Story>//
- **[3f947b1b4](facebook/react@3f947b1b4 )**: [tests] Assert scheduler log empty in internalAct ([#28737](facebook/react#28737)) //<Ricky>//
- **[bf09089f6](facebook/react@bf09089f6 )**: Remove Scheduler.log from ReactSuspenseFuzz-test ([#28812](facebook/react#28812)) //<Ricky>//
- **[84cb3b4cb](facebook/react@84cb3b4cb )**: Hardcode disableIEWorkarounds for www ([#28811](facebook/react#28811)) //<Ricky>//
- **[2243b40ab](facebook/react@2243b40ab )**: [tests] assertLog before act in useEffectEvent ([#28763](facebook/react#28763)) //<Ricky>//
- **[dfc64c6e3](facebook/react@dfc64c6e3 )**: [tests] assertLog before act in ReactUse ([#28762](facebook/react#28762)) //<Ricky>//
- **[42eff4bc7](facebook/react@42eff4bc7 )**: [tests] Fix assertions not flushed before act ([#28745](facebook/react#28745)) //<Ricky>//
- **[ed3c65caf](facebook/react@ed3c65caf )**: Warn if outdated JSX transform is detected ([#28781](facebook/react#28781)) //<Andrew Clark>//
- **[3f9e237a2](facebook/react@3f9e237a2 )**: Fix: Suspend while recovering from hydration error ([#28800](facebook/react#28800)) //<Andrew Clark>//
- **[7f5d25e23](facebook/react@7f5d25e23 )**: Fix cloneElement using string ref w no owner ([#28797](facebook/react#28797)) //<Joseph Savona>//
- **[bf40b0244](facebook/react@bf40b0244 )**: [Fizz] Stop publishing external-runtime to stable channel ([#28796](facebook/react#28796)) //<Josh Story>//
- **[7f93cb41c](facebook/react@7f93cb41c )**: [DOM] Infer react-server entries bundles if not explicitly configured ([#28795](facebook/react#28795)) //<Josh Story>//
- **[f61316535](facebook/react@f61316535 )**: Rename SECRET INTERNALS to `__CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE` ([#28789](facebook/react#28789)) //<Sebastian Markbåge>//
- **[9644d206e](facebook/react@9644d206e )**: Soften useFormState warning ([#28788](facebook/react#28788)) //<Ricky>//
- **[c771016e1](facebook/react@c771016e1 )**: Rename The Secret Export of Server Internals ([#28786](facebook/react#28786)) //<Sebastian Markbåge>//
- **[d50323eb8](facebook/react@d50323eb8 )**: Flatten ReactSharedInternals ([#28783](facebook/react#28783)) //<Sebastian Markbåge>//
- **[f62cf8c62](facebook/react@f62cf8c62 )**: [Float] treat `props.async` in Float consistent with the rest of react-dom ([#26760](facebook/react#26760)) //<Josh Story>//
- **[dfd3d5af8](facebook/react@dfd3d5af8 )**: Add support for transition{run,start,cancel} events ([#27345](facebook/react#27345)) //<Hugo Sales>//
- **[1f8327f83](facebook/react@1f8327f83 )**: [Fiber] Use real event priority for hydration scheduling ([#28765](facebook/react#28765)) //<Josh Story>//
- **[97c90ed88](facebook/react@97c90ed88 )**: [DOM] Shrink ReactDOMCurrentDispatcher method names ([#28770](facebook/react#28770)) //<Josh Story>//
- **[9007fdc8f](facebook/react@9007fdc8f )**: [DOM] Shrink ReactDOMSharedInternals source representation ([#28771](facebook/react#28771)) //<Josh Story>//
- **[14f50ad15](facebook/react@14f50ad15 )**: [Flight] Allow lazily resolving outlined models ([#28780](facebook/react#28780)) //<Sebastian Markbåge>//
- **[4c12339ce](facebook/react@4c12339ce )**: [DOM] move `flushSync` out of the reconciler ([#28500](facebook/react#28500)) //<Josh Story>//
- **[8e1462e8c](facebook/react@8e1462e8c )**: [Fiber] Move updatePriority tracking to renderers ([#28751](facebook/react#28751)) //<Josh Story>//
- **[0b3b8a6a3](facebook/react@0b3b8a6a3 )**: jsx: Remove unnecessary hasOwnProperty check ([#28775](facebook/react#28775)) //<Andrew Clark>//
- **[2acfb7b60](facebook/react@2acfb7b60 )**: [Flight] Support FormData from Server to Client ([#28754](facebook/react#28754)) //<Sebastian Markbåge>//
- **[d1547defe](facebook/react@d1547defe )**: Fast JSX: Don't clone props object ([#28768](facebook/react#28768)) //<Andrew Clark>//
- **[bfd8da807](facebook/react@bfd8da807 )**: Make class prop resolution faster ([#28766](facebook/react#28766)) //<Andrew Clark>//
- **[cbb6f2b54](facebook/react@cbb6f2b54 )**: [Flight] Support Blobs from Server to Client ([#28755](facebook/react#28755)) //<Sebastian Markbåge>//
- **[f33a6b69c](facebook/react@f33a6b69c )**: Track Owner for Server Components in DEV ([#28753](facebook/react#28753)) //<Sebastian Markbåge>//
- **[e3ebcd54b](facebook/react@e3ebcd54b )**: Move string ref coercion to JSX runtime ([#28473](facebook/react#28473)) //<Andrew Clark>//
- **[fd0da3eef](facebook/react@fd0da3eef )**: Remove _owner field from JSX elements in prod if string refs are disabled ([#28739](facebook/react#28739)) //<Sebastian Markbåge>//

Changelog:
[General][Changed] - React Native sync for revisions 48b4ecc...b5e5ce8

jest_e2e[run_all_tests]
bypass-github-export-checks

Reviewed By: kassens

Differential Revision: D56251607

fbshipit-source-id: e16db2fa101fc7ed1e009158c76388206beabd5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants