Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fizz] hoistables should never flush before the preamble #28802

Merged
merged 1 commit into from
Apr 11, 2024
Merged

[Fizz] hoistables should never flush before the preamble #28802

merged 1 commit into from
Apr 11, 2024

Commits on Apr 11, 2024

  1. [Fizz] hoistables should never flush before the preamble 

    Hoistables should never flush before the preamble however there is a surprisingly easy way to trigger this to happen by suspending in the shell of the app. This change modifies the flushing behavior to not emit any hoistables before the preamble has written. It accomplishes this by aborting the flush early if there are any pending root tasks remaining. It's unforunate we need this extra condition but it's essential that we don't emit anything before the preamble and at the moment I don't see a way to do that without introducing a new condition.
    @gnoff
    gnoff committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    018267d View commit details
    Browse the repository at this point in the history