Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure sizebot doesn't swallow large diffs #28845

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Apr 15, 2024

Sumamry

So that sizebot reports for large changes aren't swallowed like in #28827

Test plan

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 15, 2024
@react-sizebot
Copy link

react-sizebot commented Apr 15, 2024

Comparing: c8a0350...6d064cb

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 168.76 kB 168.76 kB = 52.91 kB 52.91 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 170.57 kB 170.57 kB = 53.44 kB 53.44 kB
facebook-www/ReactDOM-prod.classic.js = 590.84 kB 590.84 kB = 103.91 kB 103.91 kB
facebook-www/ReactDOM-prod.modern.js = 566.66 kB 566.66 kB = 100.10 kB 100.10 kB
test_utils/ReactAllWarnings.js Deleted 64.44 kB 0.00 kB Deleted 16.10 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.44 kB 0.00 kB Deleted 16.10 kB 0.00 kB

Generated by 🚫 dangerJS against 6d064cb

eps1lon added 2 commits April 15, 2024 22:29
Also removes console.log

Just unreadable for large messages.
@eps1lon eps1lon force-pushed the sizeboot-too-many-fix branch from 3df3e8b to b4c8d2f Compare April 15, 2024 20:29
@eps1lon eps1lon requested a review from acdlite April 15, 2024 20:32
@eps1lon eps1lon marked this pull request as ready for review April 15, 2024 20:32
@eps1lon eps1lon merged commit 8f212cc into facebook:main Apr 16, 2024
38 checks passed
@eps1lon eps1lon deleted the sizeboot-too-many-fix branch April 16, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants