Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing bundle types for ReactCacheOld #28860

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Add missing bundle types for ReactCacheOld #28860

merged 1 commit into from
Apr 18, 2024

Conversation

kassens
Copy link
Member

@kassens kassens commented Apr 18, 2024 •
edited
Loading

Add missing bundle types for ReactCacheOld

These are used at FB and we need to update them for the SecretInternals update.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 18, 2024
@react-sizebot
Copy link

react-sizebot commented Apr 18, 2024 •
edited
Loading

Comparing: 92f5c3a...baa7e2f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 168.91 kB 168.91 kB = 52.93 kB 52.93 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 170.56 kB 170.56 kB = 53.43 kB 53.43 kB
facebook-www/ReactDOM-prod.classic.js = 590.81 kB 590.81 kB = 103.90 kB 103.90 kB
facebook-www/ReactDOM-prod.modern.js = 566.62 kB 566.62 kB = 100.09 kB 100.09 kB
facebook-www/ReactCacheOld-dev.classic.js +∞% 0.00 kB 9.55 kB +∞% 0.00 kB 2.81 kB
facebook-www/ReactCacheOld-dev.modern.js +∞% 0.00 kB 9.55 kB +∞% 0.00 kB 2.81 kB
facebook-www/ReactCacheOld-prod.classic.js +∞% 0.00 kB 5.16 kB +∞% 0.00 kB 1.60 kB
facebook-www/ReactCacheOld-prod.modern.js +∞% 0.00 kB 5.16 kB +∞% 0.00 kB 1.60 kB
test_utils/ReactAllWarnings.js Deleted 64.44 kB 0.00 kB Deleted 16.10 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactCacheOld-dev.classic.js +∞% 0.00 kB 9.55 kB +∞% 0.00 kB 2.81 kB
facebook-www/ReactCacheOld-dev.modern.js +∞% 0.00 kB 9.55 kB +∞% 0.00 kB 2.81 kB
facebook-www/ReactCacheOld-prod.classic.js +∞% 0.00 kB 5.16 kB +∞% 0.00 kB 1.60 kB
facebook-www/ReactCacheOld-prod.modern.js +∞% 0.00 kB 5.16 kB +∞% 0.00 kB 1.60 kB
test_utils/ReactAllWarnings.js Deleted 64.44 kB 0.00 kB Deleted 16.10 kB 0.00 kB

Generated by 🚫 dangerJS against baa7e2f

@kassens kassens requested a review from rickhanlonii April 18, 2024 02:48
@kassens
Add missing bundle types for ReactCacheOld
baa7e2f 
These are used at FB and we need to update them for the SecretInternals update.
@kassens kassens merged commit 4c34a7f into facebook:main Apr 18, 2024
38 checks passed
@kassens kassens deleted the pr28860 branch April 18, 2024 21:26
github-actions bot pushed a commit that referenced this pull request Apr 18, 2024
@kassens
Add missing bundle types for ReactCacheOld (#28860)
f29aad9 
Add missing bundle types for ReactCacheOld

These are used at FB and we need to update them for the SecretInternals
update.

DiffTrain build for [4c34a7f](4c34a7f)
This was referenced Apr 24, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackpope jackpope jackpope approved these changes

@rickhanlonii rickhanlonii Awaiting requested review from rickhanlonii

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kassens @react-sizebot @jackpope @facebook-github-bot