Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fiber] Use Owner/JSX Stack When Appending Stacks to Console #29206

Merged
merged 7 commits into from
May 25, 2024
Merged

[Fiber] Use Owner/JSX Stack When Appending Stacks to Console #29206

merged 7 commits into from
May 25, 2024

Commits on May 23, 2024

  1. Track Stack/Task on each Fiber 

    Currently this is just keeps the original stack/task and doesn't update
with new elements, which is the same as _debugOwner but it could be changed
to update.
    @sebmarkbage
    sebmarkbage committed May 23, 2024
    Configuration menu
    Copy the full SHA
    868d4a0 View commit details
    Browse the repository at this point in the history

  2. Enable filtering of component stacks 

    Skip the React internals for the stack outside user space.
    @sebmarkbage
    sebmarkbage committed May 23, 2024
    Configuration menu
    Copy the full SHA
    91c64b3 View commit details
    Browse the repository at this point in the history

  3. Use owner stack for addendum in console.error and such

    @sebmarkbage
    sebmarkbage committed May 23, 2024
    Configuration menu
    Copy the full SHA
    697417a View commit details
    Browse the repository at this point in the history

  4. Prefer overriding the 'name' property of functions over displayName 

    This ensures that the name is used by real stack traces.
    @sebmarkbage
    sebmarkbage committed May 23, 2024
    Configuration menu
    Copy the full SHA
    2ccc918 View commit details
    Browse the repository at this point in the history

  5. Use parent stack in DOM nesting errors 

    They provide more context than the owner stacks since it's about parent
nesting.

We should really just use a diff view here that can highlight the affected
parent/child nodes in the diff view.
    @sebmarkbage
    sebmarkbage committed May 23, 2024
    Configuration menu
    Copy the full SHA
    ca08d8c View commit details
    Browse the repository at this point in the history

  6. Fix tests

    @sebmarkbage
    sebmarkbage committed May 23, 2024
    Configuration menu
    Copy the full SHA
    f497a1e View commit details
    Browse the repository at this point in the history

  7. Create Error/Task in the top level calls for jsxProdSignatureRunningI… 

    …nDev

To do this we need to break out the jsxDEV implementation into a helper.
    @sebmarkbage
    sebmarkbage committed May 23, 2024
    Configuration menu
    Copy the full SHA
    65d16bb View commit details
    Browse the repository at this point in the history