Add tests for ReactNativeAttributePayloadFabric.js #29608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…butePayloadFabric-test.internal.js
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Comparing: ea6e059...d928854 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
…d complex test case. Fix fastAddProperties.
NickGerleman
approved these changes
May 29, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2024
## Summary This PR add tests for `ReactNativeAttributePayloadFabric.js`. It introduces `ReactNativeAttributePayloadFabric-test.internal.js`, which is a copy-paste of `ReactNativeAttributePayload-test.internal.js`. On top of that, there is a bunch of new test cases for the `ReactNativeAttributePayloadFabric.create` function. ## How did you test this change? ``` yarn test packages/react-native-renderer ``` DiffTrain build for commit 51dd096.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR add tests for
ReactNativeAttributePayloadFabric.js.It introduces
ReactNativeAttributePayloadFabric-test.internal.js, which is a copy-paste ofReactNativeAttributePayload-test.internal.js.On top of that, there is a bunch of new test cases for the
ReactNativeAttributePayloadFabric.createfunction.How did you test this change?