-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compiler] Option for preserving calls to useMemo/useCallback #29654
Commits on May 29, 2024
-
[compiler] Option for preserving calls to useMemo/useCallback
Summary: This adds a compiler option to not drop existing manual memoization and leaving useMemo/useCallback in the generated source. Why do we need this, given that we also have options to validate or ensure that existing memoization is preserved? It's because later diffs on this stack are designed to alter the behavior of the memoization that the compiler emits, in order to detect rules of react violations and debug issues. We don't want to change the behavior of user-level memoization, however, since doing so would be altering the semantics of the user's program in an unacceptable way. [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for fde4986 - Browse repository at this point
Copy the full SHA fde4986View commit details
Commits on May 30, 2024
-
Update on "[compiler] Option for preserving calls to useMemo/useCallb…
…ack" Summary: This adds a compiler option to not drop existing manual memoization and leaving useMemo/useCallback in the generated source. Why do we need this, given that we also have options to validate or ensure that existing memoization is preserved? It's because later diffs on this stack are designed to alter the behavior of the memoization that the compiler emits, in order to detect rules of react violations and debug issues. We don't want to change the behavior of user-level memoization, however, since doing so would be altering the semantics of the user's program in an unacceptable way. [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for a54d96c - Browse repository at this point
Copy the full SHA a54d96cView commit details
Commits on May 31, 2024
-
Update on "[compiler] Option for preserving calls to useMemo/useCallb…
…ack" Summary: This adds a compiler option to not drop existing manual memoization and leaving useMemo/useCallback in the generated source. Why do we need this, given that we also have options to validate or ensure that existing memoization is preserved? It's because later diffs on this stack are designed to alter the behavior of the memoization that the compiler emits, in order to detect rules of react violations and debug issues. We don't want to change the behavior of user-level memoization, however, since doing so would be altering the semantics of the user's program in an unacceptable way. [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for d8969bb - Browse repository at this point
Copy the full SHA d8969bbView commit details -
Update on "[compiler] Option for preserving calls to useMemo/useCallb…
…ack" Summary: This adds a compiler option to not drop existing manual memoization and leaving useMemo/useCallback in the generated source. Why do we need this, given that we also have options to validate or ensure that existing memoization is preserved? It's because later diffs on this stack are designed to alter the behavior of the memoization that the compiler emits, in order to detect rules of react violations and debug issues. We don't want to change the behavior of user-level memoization, however, since doing so would be altering the semantics of the user's program in an unacceptable way. [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 663e1a7 - Browse repository at this point
Copy the full SHA 663e1a7View commit details -
Update on "[compiler] Option for preserving calls to useMemo/useCallb…
…ack" Summary: This adds a compiler option to not drop existing manual memoization and leaving useMemo/useCallback in the generated source. Why do we need this, given that we also have options to validate or ensure that existing memoization is preserved? It's because later diffs on this stack are designed to alter the behavior of the memoization that the compiler emits, in order to detect rules of react violations and debug issues. We don't want to change the behavior of user-level memoization, however, since doing so would be altering the semantics of the user's program in an unacceptable way. [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 163645a - Browse repository at this point
Copy the full SHA 163645aView commit details -
Update on "[compiler] Option for preserving calls to useMemo/useCallb…
…ack" Summary: This adds a compiler option to not drop existing manual memoization and leaving useMemo/useCallback in the generated source. Why do we need this, given that we also have options to validate or ensure that existing memoization is preserved? It's because later diffs on this stack are designed to alter the behavior of the memoization that the compiler emits, in order to detect rules of react violations and debug issues. We don't want to change the behavior of user-level memoization, however, since doing so would be altering the semantics of the user's program in an unacceptable way. [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for c9a2914 - Browse repository at this point
Copy the full SHA c9a2914View commit details