Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler: Allow opting out of installed library check #29742

Closed
wants to merge 3 commits into from
Closed

compiler: Allow opting out of installed library check #29742

wants to merge 3 commits into from

Conversation

josephsavona
Copy link
Contributor

@josephsavona josephsavona commented Jun 3, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Jun 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 9:25pm

josephsavona added a commit that referenced this pull request Jun 3, 2024
@josephsavona
compiler: Allow opting out of installed library check
3e4eef7 
ghstack-source-id: b161e8ae06611f906f67a9946c17362095126157
Pull Request resolved: #29742
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 3, 2024
josephsavona added a commit that referenced this pull request Jun 3, 2024
@josephsavona
compiler: Allow opting out of installed library check
9f9e33e 
ghstack-source-id: e4c70b08df35083c0c667adfe67a03156fa4f04a
Pull Request resolved: #29742
@react-sizebot
Copy link

react-sizebot commented Jun 3, 2024 •
edited
Loading

Comparing: 8c3697a...8fcda79

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.26 kB 497.26 kB = 89.11 kB 89.11 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.08 kB 502.08 kB = 89.80 kB 89.80 kB
facebook-www/ReactDOM-prod.classic.js = 594.75 kB 594.75 kB = 104.76 kB 104.76 kB
facebook-www/ReactDOM-prod.modern.js = 571.14 kB 571.14 kB = 101.18 kB 101.18 kB
test_utils/ReactAllWarnings.js Deleted 63.89 kB 0.00 kB Deleted 15.97 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 63.89 kB 0.00 kB Deleted 15.97 kB 0.00 kB

Generated by 🚫 dangerJS against 8fcda79

josephsavona added a commit that referenced this pull request Jun 3, 2024
@josephsavona
compiler: Allow opting out of installed library check
06ed4ef 
ghstack-source-id: eedd024d36f66a68abe43ba0f679e2d462b77505
Pull Request resolved: #29742
@josephsavona josephsavona deleted the gh/josephsavona/21/head branch June 3, 2024 22:31
github-actions bot pushed a commit that referenced this pull request Jun 3, 2024
@josephsavona
compiler: Allow opting out of installed library check
ce4eb81 
ghstack-source-id: eedd024d36f66a68abe43ba0f679e2d462b77505
Pull Request resolved: #29742

DiffTrain build for commit 8b677b1.
@eps1lon eps1lon mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poteto poteto poteto approved these changes

Assignees
No one assigned
Labels
CLA Signed Component: Optimizing Compiler React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephsavona @react-sizebot @poteto @facebook-github-bot