Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www: set enableRefAsProp to true #29756

Merged
merged 1 commit into from
Jun 4, 2024
Merged

www: set enableRefAsProp to true #29756

merged 1 commit into from
Jun 4, 2024

Conversation

kassens
Copy link
Member

@kassens kassens commented Jun 4, 2024

www: set enableRefAsProp to true

Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 2:58pm

@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Jun 4, 2024
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@react-sizebot
Copy link

Comparing: 4082582...796945a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.26 kB 497.26 kB = 89.11 kB 89.11 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.08 kB 502.08 kB = 89.80 kB 89.80 kB
facebook-www/ReactDOM-prod.classic.js = 594.75 kB 594.56 kB = 104.76 kB 104.72 kB
facebook-www/ReactDOM-prod.modern.js = 571.14 kB 570.95 kB = 101.18 kB 101.13 kB
facebook-www/JSXDEVRuntime-dev.modern.js = 51.86 kB 50.26 kB = 14.61 kB 14.41 kB
facebook-www/JSXDEVRuntime-dev.classic.js = 51.83 kB 50.23 kB = 14.60 kB 14.40 kB
facebook-www/React-profiling.classic.js = 23.54 kB 22.71 kB = 6.02 kB 5.90 kB
facebook-www/React-profiling.modern.js = 23.54 kB 22.71 kB = 6.02 kB 5.90 kB
facebook-www/React-prod.classic.js = 23.11 kB 22.27 kB = 5.94 kB 5.82 kB
facebook-www/React-prod.modern.js = 23.11 kB 22.27 kB = 5.94 kB 5.82 kB
test_utils/ReactAllWarnings.js Deleted 63.89 kB 0.00 kB Deleted 15.97 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/React-dev.classic.js = 117.21 kB 114.95 kB = 30.41 kB 30.13 kB
facebook-www/React-dev.modern.js = 116.72 kB 114.46 kB = 30.30 kB 30.02 kB
facebook-www/JSXDEVRuntime-dev.modern.js = 51.86 kB 50.26 kB = 14.61 kB 14.41 kB
facebook-www/JSXDEVRuntime-dev.classic.js = 51.83 kB 50.23 kB = 14.60 kB 14.40 kB
facebook-www/React-profiling.classic.js = 23.54 kB 22.71 kB = 6.02 kB 5.90 kB
facebook-www/React-profiling.modern.js = 23.54 kB 22.71 kB = 6.02 kB 5.90 kB
facebook-www/React-prod.classic.js = 23.11 kB 22.27 kB = 5.94 kB 5.82 kB
facebook-www/React-prod.modern.js = 23.11 kB 22.27 kB = 5.94 kB 5.82 kB
test_utils/ReactAllWarnings.js Deleted 63.89 kB 0.00 kB Deleted 15.97 kB 0.00 kB

Generated by 🚫 dangerJS against 796945a

@kassens kassens merged commit a26e90c into facebook:main Jun 4, 2024
40 checks passed
@kassens kassens deleted the pr29756 branch June 4, 2024 15:17
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
www: set enableRefAsProp to true

DiffTrain build for [a26e90c](a26e90c)
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
www: set enableRefAsProp to true

DiffTrain build for commit a26e90c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants