[compiler] Add repro for func properties bug with @gating #29802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
poteto
added a commit
that referenced
this pull request
Jun 7, 2024
When gating is enabled, any function declaration properties that were previously set (typically `Function.displayName`) would cause a crash after compilation as the original identifier is no longer present. ghstack-source-id: 7a7ad23cd1f64bc7bb369353b52f26ae58da206a Pull Request resolved: #29802
facebook-github-bot
added
CLA Signed
React Core Team
poteto
added a commit
that referenced
this pull request
Jun 7, 2024
When gating is enabled, any function declaration properties that were previously set (typically `Function.displayName`) would cause a crash after compilation as the original identifier is no longer present. ghstack-source-id: beb7e258561ea598d306fa67706d34a8788d9322 Pull Request resolved: #29802
|
Comparing: 0a5e0b0...322de2e Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
josephsavona
approved these changes
Jun 7, 2024
poteto
added a commit
that referenced
this pull request
Jun 7, 2024
When gating is enabled, any function declaration properties that were previously set (typically `Function.displayName`) would cause a crash after compilation as the original identifier is no longer present. ghstack-source-id: beb7e258561ea598d306fa67706d34a8788d9322 Pull Request resolved: #29802
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
When gating is enabled, any function declaration properties that were
previously set (typically
Function.displayName) would cause a crashafter compilation as the original identifier is no longer present.