-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[compiler playground]: Set source as the pre-change state in HIR diff #29957
fix[compiler playground]: Set source as the pre-change state in HIR diff #29957
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comparing: 6b4646c...df682f8 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
Thanks for the PR! I’ve never actually used the diff mode for the HIR panel, because there is nothing to diff against. Would you mind changing to just make the diff source empty for this panel? Diffing against the source doesn’t make sense since they’re such different representations. |
Looks good, thank you! |
Summary
I have fixed an issue where the display of the HIR diff in the React Compiler Playground was incorrect. The HIR diff is supposed to show the pre-change state as the source, but currently, it is showing EnvironmentConfig as the pre-change state. This PR corrects this by setting the pre-change state to source instead of EnvironmentConfig.
How did you test this change?
before:
after: