fix(flight): improve stack
type check to avoid throwing on undefined
#29990
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recently, an issue on the Next.js repo arose when importing SVGs in a server component using the
svgr
Webpack loader. I tracked it down to this release and when I debugged it using the debugger in VS Code I found this line which was recently added in #29632. It explicitly checks fornull
here but apparently it can beundefined
. I added so we always fallback tonull
in the tuple but also hardened thestack
check to make sure it's astring
.How did you test this change?
I hardcoded the changes into the
react
version in use by Next.js and tested importing a SVG which works fine.