Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add process_artifacts_combined job #30073

Merged
merged 26 commits into from
Jul 12, 2024
Merged

Conversation

[ghstack-poisoned]
Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 3:11pm

poteto added 2 commits June 24, 2024 17:15
[ghstack-poisoned]
[ghstack-poisoned]
@react-sizebot
Copy link

react-sizebot commented Jun 24, 2024

Comparing: e6783e7...a667ea2

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.99 kB 497.99 kB = 89.27 kB 89.27 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.81 kB 502.81 kB = 89.97 kB 89.97 kB
facebook-www/ReactDOM-prod.classic.js = 597.08 kB 597.08 kB = 105.33 kB 105.33 kB
facebook-www/ReactDOM-prod.modern.js = 571.42 kB 571.42 kB = 101.27 kB 101.27 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Generated by 🚫 dangerJS against a667ea2

poteto added 3 commits June 24, 2024 17:23
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@poteto poteto marked this pull request as ready for review July 1, 2024 13:15
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
poteto added a commit to poteto/react that referenced this pull request Jul 10, 2024
ghstack-source-id: 9bafffd0b2a200225d068148b1ccafa81070c051
Pull Request resolved: facebook#30073
poteto added a commit that referenced this pull request Jul 11, 2024
ghstack-source-id: 9bafffd0b2a200225d068148b1ccafa81070c051
Pull Request resolved: #30073
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 11, 2024
ghstack-source-id: 557a3079e58a752631a46f050b1775e8ad6d3c15
Pull Request resolved: #30073
poteto added a commit that referenced this pull request Jul 11, 2024
ghstack-source-id: 557a3079e58a752631a46f050b1775e8ad6d3c15
Pull Request resolved: #30073
poteto added a commit that referenced this pull request Jul 11, 2024
ghstack-source-id: 557a3079e58a752631a46f050b1775e8ad6d3c15
Pull Request resolved: #30073
poteto added a commit that referenced this pull request Jul 12, 2024
ghstack-source-id: 557a3079e58a752631a46f050b1775e8ad6d3c15
Pull Request resolved: #30073
[ghstack-poisoned]
- name: Display structure of build
run: ls -R build
- run: echo ${{ github.sha }} >> build/COMMIT_SHA
- name: Scrape warning messages
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this used to be a separate job in circleci but it was really unnecessary to spin up a new CI worker just for this. So I merged this step into process artifacts since it's the only job that needs this.

@poteto poteto merged commit 2533d2c into gh/poteto/27/base Jul 12, 2024
182 checks passed
poteto added a commit that referenced this pull request Jul 12, 2024
ghstack-source-id: 784640da83c93c49f1d924f8fcb848c7dc7d9e1c
Pull Request resolved: #30073
@poteto poteto deleted the gh/poteto/27/head branch July 12, 2024 16:09
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
ghstack-source-id: 784640da83c93c49f1d924f8fcb848c7dc7d9e1c
Pull Request resolved: facebook#30073
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants