[Fizz] Gate legacyContext field on disableLegacyContext #30173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
force-pushed
the
fizzlegacycontext
branch
from
b21603f to
1d8abc5
Compare
kassens
approved these changes
Jul 1, 2024
sebmarkbage
commented
Jul 1, 2024
| context: ContextSnapshot, // the current new context that this task is executing in | ||
| treeContext: TreeContext, // the current tree context that this task is executing in | ||
| componentStack: null | ComponentStackNode, // stack frame description of the currently rendering component | ||
| thenableState: null | ThenableState, | ||
| isFallback: boolean, // whether this task is rendering inside a fallback tree | ||
| legacyContext: LegacyContext, // the current legacy context that this task is executing in | ||
| // DON'T ANY MORE FIELDS. We at 16 already which otherwise requires converting to a constructor. |
There was a problem hiding this comment.
@kassens Fastest way to construct an object in all VMs is inline objects. However only up to 16 fields. After that we need to switch to using a constructor instead to avoid V8 deopting them. These objects are not super rare so too many fields is not good anyway.
There was a problem hiding this comment.
Cheers, assumed it was something like this but didn't know the case or limit.
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're running out of fields and this one we can avoid at runtime in any modern builds.