[compiler][ez] Upgrade babel generator version for playground #30341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jul 15, 2024
facebook-github-bot
added
the
React Core Team
poteto
approved these changes
Jul 15, 2024
…und" --- The current version of `babel/generator` used by playground has some bugs (see babel/babel#10966) ```js // Try pasting this into playground function useFoo(a, b) { return (a ?? b) == c; } // Current playground output function useFoo(a, b) { return a ?? b == c; } ``` We previously locked babel library versions to be compatible with the oldest Meta internal usages. Now that both compiler and eslint plugins are bundled with rollup, this shouldn't be necessary. [ghstack-poisoned]
mofeiZ
added a commit
that referenced
this pull request
Jul 15, 2024
--- The current version of `@babel/generator` used by playground has some bugs (see babel/babel#10966) ```js // Try pasting this into playground function useFoo(a, b) { return (a ?? b) == c; } // Current playground output function useFoo(a, b) { return a ?? b == c; } ``` We previously locked babel library versions to be compatible with the oldest Meta internal usages. Now that both compiler and eslint plugins are bundled with rollup, this shouldn't be necessary. ghstack-source-id: fa20d676b526d279817d1488f117262aa0869622 Pull Request resolved: #30341
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
--- The current version of `@babel/generator` used by playground has some bugs (see babel/babel#10966) ```js // Try pasting this into playground function useFoo(a, b) { return (a ?? b) == c; } // Current playground output function useFoo(a, b) { return a ?? b == c; } ``` We previously locked babel library versions to be compatible with the oldest Meta internal usages. Now that both compiler and eslint plugins are bundled with rollup, this shouldn't be necessary. ghstack-source-id: fa20d676b526d279817d1488f117262aa0869622 Pull Request resolved: facebook#30341
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
--- The current version of `@babel/generator` used by playground has some bugs (see babel/babel#10966) ```js // Try pasting this into playground function useFoo(a, b) { return (a ?? b) == c; } // Current playground output function useFoo(a, b) { return a ?? b == c; } ``` We previously locked babel library versions to be compatible with the oldest Meta internal usages. Now that both compiler and eslint plugins are bundled with rollup, this shouldn't be necessary. ghstack-source-id: fa20d676b526d279817d1488f117262aa0869622 Pull Request resolved: facebook#30341
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The current version of
@babel/generatorused by playground has some bugs (see babel/babel#10966)We previously locked babel library versions to be compatible with the oldest Meta internal usages. Now that both compiler and eslint plugins are bundled with rollup, this shouldn't be necessary.