Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replaced links built with Google URL Shortener with full URLs. #30411

Closed

Conversation

ryohidaka
Copy link

@ryohidaka ryohidaka commented Jul 20, 2024

Summary

Replaced links built with Google URL Shortener with full URLs. (https://goo.gl/*)

Why

Since it was announced that Google URL Shortener will no longer be supported after August 2025

Additional

The redirect for https://goo.gl/fbAQLP was to the following link.

However, it was further redirected to jestjs.io from here, so the URL finally reached is adopted.

Notes

I tried to create an Issue, but there was no corresponding topic, so I created a PR directly.

How did you test this change?

I have run prettier, linter, test and confirmed that everything is fine.
(Just correcting a comment, but just in case)

Copy link

vercel bot commented Jul 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2024 7:51am

@poteto
Copy link
Member

poteto commented Jul 26, 2024

hey, thanks for the contribution! these links are emitted by Jest however so updating snapshots would override them back to their shortened version. i think you'll need to submit a PR upstream to Jest first and then open a PR here to update

@gaearon gaearon closed this Aug 1, 2024
@ryohidaka
Copy link
Author

ryohidaka commented Aug 4, 2024

@poteto
Thank you for your comment.
I have created a PR for jest below.

jestjs/jest#15221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants