[compiler] Patch error reporting for blocklisted imports #30652
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Call
handleError
to log (and throw, depending onpanicThreshold
) instead of always throwing an exception. Discovered when syncing internally and failing the babel buildAlso added a comment to
compileProgram
for future reference (pasted below)compileProgram
is directly invoked by the react-compiler babel plugin, so exceptions thrown by this function will fail the babel build.handleError
if your error is recoverable.Unless the error is a warning / info diagnostic, compilation of a function / entire file should also be skipped.
Examples of this are invalid compiler configs or failure to codegen outlined functions after already emitting optimized components / hooks that invoke the outlined functions.
It looks like this wasn't caught in #30643 because we run snap tests with
panicThreshold: 'all_errors'
. Thoughts on switching topanicThreshold: 'none'
and explicitly labeling fatal errors vs compilation skipped?