-
Notifications
You must be signed in to change notification settings - Fork 47.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compiler] Fixture to show ref-in-render enforcement issue with useCallback #30714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llback Test Plan: Documents that useCallback calls interfere with it being ok for refs to escape as part of functions into jsx [ghstack-poisoned]
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Aug 15, 2024
… with useCallback" Test Plan: Documents that useCallback calls interfere with it being ok for refs to escape as part of functions into jsx [ghstack-poisoned]
josephsavona
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this case is interesting. we don't know when the prop will be called, so we probably should be permissive and allow it since the callback could be called during an event/effect
… with useCallback" Test Plan: Documents that useCallback calls interfere with it being ok for refs to escape as part of functions into jsx [ghstack-poisoned]
This was referenced Aug 16, 2024
… with useCallback" Test Plan: Documents that useCallback calls interfere with it being ok for refs to escape as part of functions into jsx [ghstack-poisoned]
… with useCallback" Test Plan: Documents that useCallback calls interfere with it being ok for refs to escape as part of functions into jsx [ghstack-poisoned]
mvitousek
added a commit
that referenced
this pull request
Aug 16, 2024
…llback Test Plan: Documents that useCallback calls interfere with it being ok for refs to escape as part of functions into jsx ghstack-source-id: a5df427981ca32406fb2325e583b64bbe26b1cdd Pull Request resolved: #30714
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Test Plan:
Documents that useCallback calls interfere with it being ok for refs to escape as part of functions into jsx