Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevTools] Refactor Forcing Fallback / Error of Suspense / Error Boundaries #30870

Merged
merged 5 commits into from
Sep 5, 2024
Merged

[DevTools] Refactor Forcing Fallback / Error of Suspense / Error Boundaries #30870

merged 5 commits into from
Sep 5, 2024

Commits on Sep 5, 2024

  1. Move force error/fallback into Fiber Maps instead of Flags

    @sebmarkbage
    sebmarkbage committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    6c71acf View commit details
    Browse the repository at this point in the history

  2. Compute targetErrorBoundaryID lazily when we actually try to set an e… 

    …rror

This lets us find the nearest error boundary even if it is filtered and
don't have an ID.
    @sebmarkbage
    sebmarkbage committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    da1ad12 View commit details
    Browse the repository at this point in the history

  3. Compute Suspense boundary to Force in the Backend 

    This ensures we can suspend the nearest Suspense boundary even if it is
filtered and unifies with Error Boundaries.
    @sebmarkbage
    sebmarkbage committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    1a49cac View commit details
    Browse the repository at this point in the history

  4. Support Suspending/Erroring Virtual Instances 

    This finds the nearest Fiber Instance downwards filtered or otherwise.
Then from its parent we find the nearest Error or Suspense boundary.

That's because VirtualInstance will always have their inner Fiber as an
Instance but they might not have their parent since it might be filtered.
    @sebmarkbage
    sebmarkbage committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    66b5559 View commit details
    Browse the repository at this point in the history

  5. Track if inside suspense or error boundary to highlight the buttons

    @sebmarkbage
    sebmarkbage committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c7221da View commit details
    Browse the repository at this point in the history