[rcr] Remove runtimeModule compiler option #31055

poteto · 2024-09-24T22:43:52Z

Stack from ghstack (oldest at bottom):

Now that the compiler always injects react-compiler-runtime, this
option is unnecessary.

[ghstack-poisoned]

vercel · 2024-09-24T22:43:54Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 2, 2024 6:59pm

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: f0c73da Pull Request resolved: #31055

[ghstack-poisoned]

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: b6990b2 Pull Request resolved: #31055

[ghstack-poisoned]

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 0c65d96 Pull Request resolved: #31055

[ghstack-poisoned]

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 159d6c4 Pull Request resolved: #31055

[ghstack-poisoned]

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 85e32a6 Pull Request resolved: #31055

[ghstack-poisoned]

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: c12286c Pull Request resolved: #31055

[ghstack-poisoned]

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: b8d31c1 Pull Request resolved: #31055

[ghstack-poisoned]

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: d0c9cc9 Pull Request resolved: #31055

[ghstack-poisoned]

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 788fd4f Pull Request resolved: #31055

[ghstack-poisoned]

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 93379c6 Pull Request resolved: #31055

josephsavona · 2024-09-27T20:45:25Z

Hmmm feels like we might want to keep this option for use internally where we're always on latest?

[ghstack-poisoned]

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: d8f7403 Pull Request resolved: #31055

poteto · 2024-10-01T18:20:33Z

@josephsavona hmm the new react-compiler-runtime already defers to the latest impl, and with this stack it's always added as a dep in codegen so this option isn't really necessary anymore

[ghstack-poisoned]

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 7ce2b97 Pull Request resolved: #31055

[ghstack-poisoned]

Update

60c4e63

[ghstack-poisoned]

poteto added a commit that referenced this pull request Sep 24, 2024

[rcr] Remove runtimeModule compiler option

4e359ba

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: f0c73da Pull Request resolved: #31055

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 24, 2024

vercel bot deployed to Preview September 24, 2024 22:49 View deployment

poteto added a commit that referenced this pull request Sep 24, 2024

[rcr] Remove runtimeModule compiler option

6febb68

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: f0c73da Pull Request resolved: #31055

Update

29f1329

[ghstack-poisoned]

poteto added a commit that referenced this pull request Sep 24, 2024

[rcr] Remove runtimeModule compiler option

6a09b10

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: b6990b2 Pull Request resolved: #31055

vercel bot deployed to Preview September 24, 2024 23:00 View deployment

Update

47cdefa

[ghstack-poisoned]

poteto added a commit that referenced this pull request Sep 26, 2024

[rcr] Remove runtimeModule compiler option

5f4eff9

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 0c65d96 Pull Request resolved: #31055

vercel bot had a problem deploying to Preview September 26, 2024 18:44 Failure

Update

5c01aad

[ghstack-poisoned]

poteto added a commit that referenced this pull request Sep 26, 2024

[rcr] Remove runtimeModule compiler option

3232c83

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 159d6c4 Pull Request resolved: #31055

vercel bot had a problem deploying to Preview September 26, 2024 18:54 Failure

Update

9ca2c4a

[ghstack-poisoned]

poteto mentioned this pull request Sep 26, 2024

[playground] Update react version to dedupe deps #31077

Closed

poteto added a commit that referenced this pull request Sep 26, 2024

[rcr] Remove runtimeModule compiler option

d832837

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 85e32a6 Pull Request resolved: #31055

vercel bot had a problem deploying to Preview September 26, 2024 19:24 Failure

Update

46acabf

[ghstack-poisoned]

poteto mentioned this pull request Sep 26, 2024

[compiler] Fix broken tests #31078

Merged

poteto added a commit that referenced this pull request Sep 26, 2024

[rcr] Remove runtimeModule compiler option

ca4aab7

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: c12286c Pull Request resolved: #31055

vercel bot had a problem deploying to Preview September 26, 2024 19:59 Failure

rebase

229a882

[ghstack-poisoned]

Update

9e71458

[ghstack-poisoned]

poteto added a commit that referenced this pull request Sep 27, 2024

[rcr] Remove runtimeModule compiler option

e6926c4

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: b8d31c1 Pull Request resolved: #31055

Update

dc1f490

[ghstack-poisoned]

poteto added a commit that referenced this pull request Sep 27, 2024

[rcr] Remove runtimeModule compiler option

7504b22

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: d0c9cc9 Pull Request resolved: #31055

vercel bot deployed to Preview September 27, 2024 20:06 View deployment

Update

e82c1cc

[ghstack-poisoned]

poteto added a commit that referenced this pull request Sep 27, 2024

[rcr] Remove runtimeModule compiler option

2ff8deb

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 788fd4f Pull Request resolved: #31055

vercel bot deployed to Preview September 27, 2024 20:11 View deployment

Update

1912000

[ghstack-poisoned]

poteto added a commit that referenced this pull request Sep 27, 2024

[rcr] Remove runtimeModule compiler option

544191c

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 93379c6 Pull Request resolved: #31055

vercel bot deployed to Preview September 27, 2024 20:16 View deployment

Update

026ba4e

[ghstack-poisoned]

poteto added a commit that referenced this pull request Oct 1, 2024

[rcr] Remove runtimeModule compiler option

1bfdbda

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: d8f7403 Pull Request resolved: #31055

vercel bot deployed to Preview October 1, 2024 14:12 View deployment

Update

b8f628f

[ghstack-poisoned]

poteto added a commit that referenced this pull request Oct 1, 2024

[rcr] Remove runtimeModule compiler option

5004927

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 7ce2b97 Pull Request resolved: #31055

poteto added a commit that referenced this pull request Oct 1, 2024

[rcr] Remove runtimeModule compiler option

c729d99

Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 7ce2b97 Pull Request resolved: #31055

vercel bot deployed to Preview October 1, 2024 18:24 View deployment

Update

e3b0f2b

[ghstack-poisoned]

poteto mentioned this pull request Oct 1, 2024

[rcr][ez] Clean up unused $read from rcr #31110

Closed

poteto marked this pull request as ready for review October 1, 2024 18:27

Update

3e192c3

[ghstack-poisoned]

vercel bot deployed to Preview October 1, 2024 18:30 View deployment

vercel bot deployed to Preview October 1, 2024 18:37 View deployment

Update

0dcc910

[ghstack-poisoned]

vercel bot deployed to Preview October 2, 2024 18:59 View deployment

poteto closed this Oct 7, 2024

poteto deleted the gh/poteto/14/head branch November 18, 2024 15:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[rcr] Remove runtimeModule compiler option #31055

[rcr] Remove runtimeModule compiler option #31055

Uh oh!

poteto commented Sep 24, 2024 •

edited

Loading

Uh oh!

vercel bot commented Sep 24, 2024 •

edited

Loading

Uh oh!

josephsavona commented Sep 27, 2024

Uh oh!

poteto commented Oct 1, 2024

Uh oh!

Uh oh!

[rcr] Remove runtimeModule compiler option #31055

[rcr] Remove runtimeModule compiler option #31055

Uh oh!

Conversation

poteto commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

josephsavona commented Sep 27, 2024

Uh oh!

poteto commented Oct 1, 2024

Uh oh!

Uh oh!

poteto commented Sep 24, 2024 •

edited

Loading

vercel bot commented Sep 24, 2024 •

edited

Loading