Define HostInstance type for React Native
#31101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yungsters
commented
Sep 30, 2024
|
|
||
| // This validates that INativeMethods and NativeMethods stay in sync using Flow! | ||
| declare const ensureNativeMethodsAreSynced: NativeMethods; | ||
| (ensureNativeMethodsAreSynced: INativeMethods); | ||
|
|
||
| export type HostComponent<T> = AbstractComponent<T, $ReadOnly<NativeMethods>>; | ||
| export type HostInstance = NativeMethods; |
There was a problem hiding this comment.
I tried to make this INativeMethods, but that's going to require its own initiative.
Too many call sites are relying on the ability to spread this type into another object type in order to augment it. (Questionable, but alas… the codebase must grow.)
NickGerleman
approved these changes
Oct 1, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
## Summary Creates a new `HostInstance` type for React Native, to more accurately capture the intent most developers have when using the `NativeMethods` type or `React.ElementRef<HostComponent<T>>`. Since `React.ElementRef<HostComponent<T>>` is typed as `React.AbstractComponent<T, NativeMethods>`, that means `React.ElementRef<HostComponent<T>>` is equivalent to `NativeMethods` which is equivalent to `HostInstance`. ## How did you test this change? ``` $ yarn $ yarn flow fabric ``` DiffTrain build for [459fd41](459fd41)
This was referenced Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Creates a new
HostInstancetype for React Native, to more accurately capture the intent most developers have when using theNativeMethodstype orReact.ElementRef<HostComponent<T>>.Since
React.ElementRef<HostComponent<T>>is typed asReact.AbstractComponent<T, NativeMethods>, that meansReact.ElementRef<HostComponent<T>>is equivalent toNativeMethodswhich is equivalent toHostInstance.How did you test this change?