refactor[react-devtools]: flatten reload and profile config #31132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
hoxyq
force-pushed
the
react-devtools/flatten-reload-and-profile
branch
from
f97ae1d to
4962982
Compare
hoxyq
force-pushed
the
react-devtools/flatten-reload-and-profile
branch
from
4962982 to
b4b3148
Compare
hoxyq
force-pushed
the
react-devtools/flatten-reload-and-profile
branch
from
b4b3148 to
8206fba
Compare
hoxyq
force-pushed
the
react-devtools/flatten-reload-and-profile
branch
from
8206fba to
7a49d46
Compare
EdmondChuiHW
approved these changes
Oct 9, 2024
| @@ -16,7 +16,6 @@ export function createStore(bridge: FrontendBridge, config?: Config): Store { | |||
| return new Store(bridge, { | |||
| checkBridgeProtocolCompatibility: true, | |||
| supportsTraceUpdates: true, | |||
| supportsTimeline: true, | |||
There was a problem hiding this comment.
Yes, it was intended, but let me revert this to how it was previously implemented.
Comment on lines
+147
to
+155
| // Agent read flags successfully, we can count it as successful launch | ||
| // Clean up flags, so that next reload won't start profiling | ||
| onReloadAndProfileFlagsReset(); |
There was a problem hiding this comment.
Is this a safe assumption? Would it be possible that rendering/profiling start async/later somehow?
There was a problem hiding this comment.
Yes, because these are reload and profile flags. If Backend was reloaded for profiling, then we should've already read them, when Hook is initialized, or when Agent is constructed.
This doesn't affect basic profiling without reloading.
hoxyq
force-pushed
the
react-devtools/flatten-reload-and-profile
branch
2 times, most recently
from
d56ef66 to
2467fcc
Compare
hoxyq
force-pushed
the
react-devtools/flatten-reload-and-profile
branch
from
2467fcc to
31b9b70
Compare
hoxyq
force-pushed
the
react-devtools/flatten-reload-and-profile
branch
from
31b9b70 to
798af8b
Compare
hoxyq
added a commit
that referenced
this pull request
Oct 9, 2024
Stacked on #31132. See last commit. There are 2 issues: 1. We've been recording timeline events, even if Timeline Profiler was not supported by the Host. We've been doing this for React Native, for example, which would significantly regress perf of recording a profiling session, but we were not even using this data. 2. Currently, we are generating component stack for every state update event. This is extremely expensive, and we should not be doing this. We can't currently fix the second one, because we would still need to generate all these stacks, and this would still take quite a lot of time. As of right now, we can't generate a component stack lazily without relying on the fact that reference to the Fiber is not stale. With `enableOwnerStacks` we could populate component stacks in some collection, which would be cached at the Backend, and then returned only once Frontend asks for it. This approach also eliminates the need for keeping a reference to a Fiber.
This was referenced Oct 9, 2024
hoxyq
added a commit
that referenced
this pull request
Oct 15, 2024
Changes in this release: * Fix React Compiler badging ([poteto](https://github.com/poteto) in [#31196](#31196)) * fix[react-devtools]: fixed timeline profiler tests ([hoxyq](https://github.com/hoxyq) in [#31261](#31261)) * fix[react-devtools]: record timeline data only when supported ([hoxyq](https://github.com/hoxyq) in [#31154](#31154)) * refactor[react-devtools]: flatten reload and profile config ([hoxyq](https://github.com/hoxyq) in [#31132](#31132)) * fix[react-devtools]: remove all listeners when Agent is shutdown ([hoxyq](https://github.com/hoxyq) in [#31151](#31151)) * fix[react-devtools]: removed redundant startProfiling call ([hoxyq](https://github.com/hoxyq) in [#31131](#31131)) * refactor[react-devtools/fiber/renderer]: optimize durations resolution ([hoxyq](https://github.com/hoxyq) in [#31118](#31118)) * fix[react-devtools]: update profiling status before receiving response from backend ([hoxyq](https://github.com/hoxyq) in [#31117](#31117)) * fix[react-devtools]: wrap key string in preformatted text html element ([hoxyq](https://github.com/hoxyq) in [#31153](#31153)) * chore[react-devtools]: drop legacy context tests ([hoxyq](https://github.com/hoxyq) in [#31059](#31059)) * chore[react-devtools]: add legacy mode error message to the ignore list for tests ([hoxyq](https://github.com/hoxyq) in [#31060](#31060)) * fix[react-devtools]: request hook initialization inside http server response ([hoxyq](https://github.com/hoxyq) in [#31102](#31102)) * [Flight] Serialize Server Components Props in DEV ([sebmarkbage](https://github.com/sebmarkbage) in [#31105](#31105)) * Add: reload to profile for Fusebox ([EdmondChuiHW](https://github.com/EdmondChuiHW) in [#31021](#31021)) * refactor: allow custom impl of backend realod-to-profile support check ([EdmondChuiHW](https://github.com/EdmondChuiHW) in [#31048](#31048)) * fix: use public instance in Fiber renderer and expose it from getInspectorDataForViewAtPoint ([hoxyq](https://github.com/hoxyq) in [#31068](#31068))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #31131. See last commit.
This is a clean-up and a pre-requisite for next changes:
ReloadAndProfileConfigis now split into boolean value and settings object. This is mainly because I will add one more setting soon, and also because settings might be persisted for a longer time than the flag which signals if the Backend was reloaded for profiling. Ideally, this settings should probably be moved to the global Hook object, same as we did for console patching.onReloadAndProfileFlagsResetcallback.