[rcr] Remove runtimeModule compiler option #31145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Oct 7, 2024
poteto
added a commit
that referenced
this pull request
Oct 7, 2024
Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 8141f6dfef33cd85b6bee93926fde53f8c9f2d0f ghstack-comment-id: 2397700297 Pull Request resolved: #31145
facebook-github-bot
added
CLA Signed
React Core Team
poteto
added a commit
that referenced
this pull request
Oct 7, 2024
Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 8141f6dfef33cd85b6bee93926fde53f8c9f2d0f ghstack-comment-id: 2397700297 Pull Request resolved: #31145
poteto
added a commit
that referenced
this pull request
Oct 7, 2024
Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: ec5ff3eb0bfd74ff9b96214df4601d417aae71c4 ghstack-comment-id: 2397700297 Pull Request resolved: #31145
poteto
added a commit
that referenced
this pull request
Oct 7, 2024
Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 6ad6822793525e72635de3aec5caeb232d308ff3 ghstack-comment-id: 2397700297 Pull Request resolved: #31145
poteto
added a commit
that referenced
this pull request
Oct 7, 2024
Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 6ad6822793525e72635de3aec5caeb232d308ff3 ghstack-comment-id: 2397700297 Pull Request resolved: #31145
poteto
force-pushed
the
gh/poteto/30/head
branch
from
0d8cf4b to
c2c5431
Compare
poteto
added a commit
that referenced
this pull request
Oct 7, 2024
Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 6ad6822793525e72635de3aec5caeb232d308ff3 ghstack-comment-id: 2397700297 Pull Request resolved: #31145
This was referenced Oct 8, 2024
9 tasks
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the compiler always injects
react-compiler-runtime, thisoption is unnecessary.