[Flight] Also don't cut off type and key #31209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
force-pushed
the
fixdepthserialization
branch
from
4aeec0c to
db08d25
Compare
sebmarkbage
commented
Oct 13, 2024
| // eslint-disable-next-line no-throw-literal | ||
| throw ( | ||
| // TODO: We should ideally throw here to indicate a difference. | ||
| return ( |
There was a problem hiding this comment.
This is a workaround because we read model[0] in two places in our own parsing which triggers this throw.
eps1lon
approved these changes
Oct 13, 2024
eps1lon
approved these changes
Oct 13, 2024
eps1lon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #31179