Skip to content

[Flight] Support Async Modules in Server References #31313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2024
Merged

[Flight] Support Async Modules in Server References #31313

merged 1 commit into from
Oct 21, 2024

Conversation

sebmarkbage
Copy link
Collaborator

This is required to support for example top level await in a "use server" module or dependency of a "use server".

@sebmarkbage sebmarkbage requested a review from gnoff October 21, 2024 18:44
@vercel Vercel
Copy link

vercel bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 6:48pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 21, 2024
@react-sizebot
Copy link

Comparing: 65a56d0...201f71b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 506.86 kB 506.86 kB = 90.71 kB 90.71 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 511.79 kB 511.79 kB = 91.43 kB 91.42 kB
facebook-www/ReactDOM-prod.classic.js = 604.26 kB 604.26 kB = 106.92 kB 106.92 kB
facebook-www/ReactDOM-prod.modern.js = 580.48 kB 580.48 kB = 103.00 kB 103.01 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 08f3998

@sebmarkbage sebmarkbage merged commit 69d4b80 into facebook:main Oct 21, 2024
182 checks passed
@vercel-release-bot vercel-release-bot mentioned this pull request Oct 21, 2024
Merged
@sebmarkbage sebmarkbage mentioned this pull request Oct 21, 2024
Closed
@unstubbable unstubbable mentioned this pull request Oct 21, 2024
Merged
sebmarkbage pushed a commit to vercel/next.js that referenced this pull request Oct 21, 2024
@vercel-release-bot
Upgrade React from 65a56d0e-20241020 to 69d4b800-20241021 (#71568)
8a905cf 
**breaking change for canary users: Bumps peer dependency of React from
`19.0.0-rc-65a56d0e-20241020` to `19.0.0-rc-69d4b800-20241021`**

[diff
facebook/react@65a56d0e...69d4b800](facebook/react@65a56d0...69d4b80)

<details>
<summary>React upstream changes</summary>

- facebook/react#31313

</details>
@hi-ogawa hi-ogawa mentioned this pull request Mar 28, 2025
Merged
@lubieowoce lubieowoce mentioned this pull request Sep 19, 2025
Merged
gnoff pushed a commit that referenced this pull request Sep 19, 2025
@lubieowoce
[Flight] Support Async Modules in Turbopack Server References (#34531)
01cad9e 
Seems like this was missed in
#31313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnoff gnoff gnoff approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sebmarkbage @react-sizebot @gnoff @facebook-github-bot