Upgrade devtools dependency update-notifier to 5.x#31655
Merged
hoxyq merged 1 commit intofacebook:mainfrom Nov 7, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stianjensen
force-pushed
the
upgrade-update-notifier
branch
from
4524492 to
ab2ff7f
Compare
stianjensen
force-pushed
the
upgrade-update-notifier
branch
from
ab2ff7f to
a98de75
Compare
stianjensen
force-pushed
the
upgrade-update-notifier
branch
from
a98de75 to
c2b125a
Compare
stianjensen
force-pushed
the
upgrade-update-notifier
branch
from
c2b125a to
a74c139
Compare
Member
This is the latest non-ESM version, so upgrading to it should be unproblematic (while updating to 6.x and beyond will have to wait). Upgrading means we avoid installing a lot of outdated dependencies, and resolves part of facebook#28058 Changelog: https://github.com/yeoman/update-notifier/releases The most relevant breaking change seems to be that the minimum support node version is increased from v6 to v10, but I couldn't find what is currently React's official node version support.
stianjensen
force-pushed
the
upgrade-update-notifier
branch
from
a74c139 to
c9ea15d
Compare
|
Comparing: dd048c3...c9ea15d Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the dependency on update-notifier, used in react-devtools, to 5.x
This is the latest non-ESM version, so upgrading to it should be unproblematic (while updating to 6.x and beyond will have to wait).
Upgrading means we avoid installing a lot of outdated dependencies (as can be seen from the diff in yarn.lock), and resolves part of #28058
Changelog:
https://github.com/yeoman/update-notifier/releases
The most relevant breaking change seems to be that the minimum support node version is increased from v6 to v10, but I couldn't find what is currently React's official node version support.
How did you test this change?
I ran the test-suite locally (
yarn testin root folder), but I'm not sure if that one actually covers devtools?I also built and tested this version of devtools with some internal company projects (both react and react-native based) – following guidelines from #28058 (comment).