[Fiber] Log Effect and Render Times in Offscreen Commit Phase #31788
+183
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: f5077bc...7aaac76 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
sebmarkbage
commented
Dec 15, 2024
| @@ -4191,7 +4191,7 @@ function doubleInvokeEffectsOnFiber( | |||
| } | |||
| reappearLayoutEffects(root, fiber.alternate, fiber, false); | |||
| if (shouldDoubleInvokePassiveEffects) { | |||
| reconnectPassiveEffects(root, fiber, NoLanes, null, false); | |||
| reconnectPassiveEffects(root, fiber, NoLanes, null, false, 0); | |||
There was a problem hiding this comment.
It's not a new issue in this PR but an existing issue is that all these phases end up double logging the effects.
sebmarkbage
force-pushed
the
renderperfphase
branch
from
69e5990 to
6ecfbf7
Compare
sebmarkbage
force-pushed
the
renderperfphase
branch
from
6ecfbf7 to
636fae0
Compare
sebmarkbage
changed the title
…ffscreen subtrees This includes initial mount of a Suspense boundary.
sebmarkbage
force-pushed
the
renderperfphase
branch
from
636fae0 to
c18813c
Compare
acdlite
approved these changes
Dec 17, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
In #30967 and #30983 I added logging of the just rendered components and the effects. However this didn't consider the special Offscreen passes. So this adds the same thing to those passes. Log component effect timings for disconnected/reconnected offscreen subtrees. This includes initial mount of a Suspense boundary. Log component render timings for reconnected and already offscreen offscreen subtrees. DiffTrain build for [6a4b46c](6a4b46c)
github-actions bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
In #30967 and #30983 I added logging of the just rendered components and the effects. However this didn't consider the special Offscreen passes. So this adds the same thing to those passes. Log component effect timings for disconnected/reconnected offscreen subtrees. This includes initial mount of a Suspense boundary. Log component render timings for reconnected and already offscreen offscreen subtrees. DiffTrain build for [6a4b46c](6a4b46c)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Dec 18, 2024
…ok#31788) In facebook#30967 and facebook#30983 I added logging of the just rendered components and the effects. However this didn't consider the special Offscreen passes. So this adds the same thing to those passes. Log component effect timings for disconnected/reconnected offscreen subtrees. This includes initial mount of a Suspense boundary. Log component render timings for reconnected and already offscreen offscreen subtrees. DiffTrain build for [6a4b46c](facebook@6a4b46c)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Dec 18, 2024
…ok#31788) In facebook#30967 and facebook#30983 I added logging of the just rendered components and the effects. However this didn't consider the special Offscreen passes. So this adds the same thing to those passes. Log component effect timings for disconnected/reconnected offscreen subtrees. This includes initial mount of a Suspense boundary. Log component render timings for reconnected and already offscreen offscreen subtrees. DiffTrain build for [6a4b46c](facebook@6a4b46c)
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #30967 and #30983 I added logging of the just rendered components and the effects. However this didn't consider the special Offscreen passes. So this adds the same thing to those passes.
Log component effect timings for disconnected/reconnected offscreen subtrees. This includes initial mount of a Suspense boundary.
Log component render timings for reconnected and already offscreen offscreen subtrees.