[Fizz] Restore useMemoCache in renderers with support for Client APIs
#32067
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly an oversight since we don't have types based off of feature flags. Now that `enableUseMemoCache` is shipped, `useMemoCache` can be non-nullable. Discovered during integration testing with Next.js where SSR threw with `TypeError: dispatcher.useMemoCache is not a function` but ultimately recovered due to client-side rendering.
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 453f505...43df636 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
eps1lon
changed the title
useMemoCache in renderers with support for Client APIsuseMemoCache in renderers with support for Client APIs
rickhanlonii
approved these changes
Jan 14, 2025
dai-shi
reviewed
Jan 15, 2025
| @@ -834,6 +834,7 @@ export const HooksDispatcher: Dispatcher = supportsClientAPIs | |||
| useActionState, | |||
| useFormState: useActionState, | |||
| useHostTransitionStatus, | |||
| useMemoCache, | |||
There was a problem hiding this comment.
Should useCacheRefresh be added here too or not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. in
react-dom/server: https://codesandbox.io/p/sandbox/usememocache-react-dom-server-nkz4zc?file=%2Fsrc%2Findex.js%3A9%2C1Broke only recently in #31767. No stable release is affected
Summary
Mainly an oversight since we don't have types based off of feature flags. Now that
enableUseMemoCacheis shipped,useMemoCachecan be non-nullable.Discovered during integration testing with Next.js where SSR threw with
TypeError: dispatcher.useMemoCache is not a functionbut ultimately recovered due to client-side rendering.How did you test this change?
Hardened types.