Skip to content

[flags] enable owner stacks everywhere #32376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 18, 2025
Merged

[flags] enable owner stacks everywhere #32376

merged 3 commits into from
Feb 18, 2025

Conversation

rickhanlonii
Copy link
Member

this is now canary and on everywhere

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Feb 13, 2025
@react-sizebot
Copy link

react-sizebot commented Feb 13, 2025 •
edited
Loading

Comparing: 4632e36...62b6c22

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 515.71 kB 515.71 kB = 92.09 kB 92.09 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.11% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 562.25 kB 562.25 kB = 100.08 kB 100.08 kB
facebook-www/ReactDOM-prod.classic.js = 636.70 kB 636.70 kB = 112.08 kB 112.08 kB
facebook-www/ReactDOM-prod.modern.js = 627.02 kB 627.02 kB = 110.49 kB 110.50 kB
facebook-www/React-dev.classic.js = 72.23 kB 56.79 kB = 15.68 kB 12.42 kB
facebook-www/React-dev.modern.js = 72.23 kB 56.79 kB = 15.68 kB 12.42 kB
facebook-react-native/react/cjs/React-dev.js = 67.65 kB 52.36 kB = 14.85 kB 11.71 kB
facebook-www/JSXDEVRuntime-dev.classic.js = 28.79 kB 13.52 kB = 6.73 kB 3.69 kB
facebook-www/JSXDEVRuntime-dev.modern.js = 28.79 kB 13.52 kB = 6.73 kB 3.69 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js = 26.77 kB 12.08 kB = 6.31 kB 3.36 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js = 26.51 kB 11.88 kB = 6.29 kB 3.34 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
react-native/implementations/ReactFabric-dev.js +0.53% 638.67 kB 642.02 kB +0.44% 104.42 kB 104.88 kB
facebook-www/ReactTestRenderer-dev.modern.js +0.52% 573.75 kB 576.76 kB +0.58% 93.66 kB 94.20 kB
facebook-www/ReactTestRenderer-dev.classic.js +0.52% 573.76 kB 576.77 kB +0.58% 93.66 kB 94.20 kB
react-native/implementations/ReactNativeRenderer-dev.js +0.52% 647.21 kB 650.57 kB +0.47% 105.86 kB 106.36 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js +0.50% 596.84 kB 599.85 kB +0.57% 96.41 kB 96.96 kB
facebook-www/ReactReconciler-dev.classic.js = 773.31 kB 771.74 kB = 121.66 kB 121.51 kB
facebook-www/ReactReconciler-dev.modern.js = 764.10 kB 762.53 kB = 119.97 kB 119.84 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js = 679.15 kB 677.10 kB = 110.74 kB 110.40 kB
react-native/implementations/ReactFabric-dev.fb.js = 673.87 kB 671.82 kB = 109.73 kB 109.37 kB
facebook-www/ReactDOMServer-dev.classic.js = 380.98 kB 379.50 kB = 68.25 kB 68.11 kB
facebook-www/ReactDOMServer-dev.modern.js = 374.13 kB 372.65 kB = 67.25 kB 67.10 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js = 365.83 kB 364.35 kB = 65.98 kB 65.82 kB
facebook-www/React-dev.classic.js = 72.23 kB 56.79 kB = 15.68 kB 12.42 kB
facebook-www/React-dev.modern.js = 72.23 kB 56.79 kB = 15.68 kB 12.42 kB
facebook-react-native/react/cjs/React-dev.js = 67.65 kB 52.36 kB = 14.85 kB 11.71 kB
facebook-www/JSXDEVRuntime-dev.classic.js = 28.79 kB 13.52 kB = 6.73 kB 3.69 kB
facebook-www/JSXDEVRuntime-dev.modern.js = 28.79 kB 13.52 kB = 6.73 kB 3.69 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js = 26.77 kB 12.08 kB = 6.31 kB 3.36 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js = 26.51 kB 11.88 kB = 6.29 kB 3.34 kB

Generated by 🚫 dangerJS against f764b7c

@rickhanlonii rickhanlonii force-pushed the rh/owner-stack-flags-on branch from dbe6a42 to f3e156b Compare February 18, 2025 15:05
@rickhanlonii rickhanlonii merged commit 8a7b487 into facebook:main Feb 18, 2025
194 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 18, 2025
@rickhanlonii
[flags] enable owner stacks everywhere (#32376)
d81e5a9 
this is now canary and on everywhere

DiffTrain build for [8a7b487](8a7b487)
github-actions bot pushed a commit that referenced this pull request Feb 18, 2025
@rickhanlonii
[flags] enable owner stacks everywhere (#32376)
34e060a 
this is now canary and on everywhere

DiffTrain build for [8a7b487](8a7b487)
@rickhanlonii rickhanlonii mentioned this pull request Feb 19, 2025
Merged
This was referenced Feb 19, 2025
Closed
Closed
Merged
rickhanlonii added a commit that referenced this pull request Feb 24, 2025
@rickhanlonii
[flags] remove enableRemoveConsolePatches (#32425)
2567726 
wait to merge until we sync
#32376, since that enables it in
some testing builds that might break
github-actions bot pushed a commit that referenced this pull request Feb 24, 2025
@rickhanlonii
[flags] remove enableRemoveConsolePatches (#32425)
6d9586c 
wait to merge until we sync
#32376, since that enables it in
some testing builds that might break

DiffTrain build for [2567726](2567726)
github-actions bot pushed a commit that referenced this pull request Feb 24, 2025
@rickhanlonii
[flags] remove enableRemoveConsolePatches (#32425)
920b646 
wait to merge until we sync
#32376, since that enables it in
some testing builds that might break

DiffTrain build for [2567726](2567726)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rickhanlonii @react-sizebot @eps1lon @facebook-github-bot