chore: remove devEngines declaration in root package
#32398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the `devEngines` declaration in the root package. It didn't match the package.json spec and in npm 10.9.0 (released in October), a breaking change was introduced that checks the `devEngines` property. This causes `npm pack` calls to fail, due to the malformed `devEngines`. Since there's already an `.nvmrc` defined in the repo, and no strong need to enforce a specific node version for local development, this removes the declaration altogether.
michaelfaith
force-pushed
the
chore/fix-devEngines-declaration
branch
from
4a18dc7 to
035de31
Compare
michaelfaith
changed the title
devEngines declaration in root packagedevEngines declaration in root package
Member
|
Thanks! For context @michaelfaith and I discussed this offline, and we agreed that there's little value in enforcing local node versions unless one is building from source locally (which is convoluted anyway due to requiring an old version of Java). Since we already enforce this in CI in order to ensure builds work it seems fine to remove. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the
devEnginesdeclaration in the root package. It didn't match the package.json spec and in npm 10.9.0 (released in October), a breaking change was introduced that checks thedevEnginesproperty. This causesnpm packcalls to fail, due to the malformeddevEngines. Since there's already an.nvmrcdefined in the repo, and no strong need to enforce a specific node version for local development, this removes the declaration altogether.