[flags] remove enableOwnerStacks #32426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
rickhanlonii
force-pushed
the
rh/remove-ff-owner-stacks
branch
from
77946d4 to
4a1c5b4
Compare
rickhanlonii
force-pushed
the
rh/remove-ff-owner-stacks
branch
from
4a1c5b4 to
4395e47
Compare
rickhanlonii
force-pushed
the
rh/remove-ff-owner-stacks
branch
from
4395e47 to
c4da3fd
Compare
rickhanlonii
commented
Feb 23, 2025
| @@ -135,6 +135,7 @@ export function supportsConsoleTasks(fiber: Fiber): boolean { | |||
| return !!fiber._debugTask; | |||
| } | |||
|
|
|||
| // TODO: clean this up? | |||
There was a problem hiding this comment.
@sebmarkbage is it safe for me to delete this? Not sure about devtools versioning
There was a problem hiding this comment.
No it's not safe to delete because this is the feature detection whether this version of React supports owner stacks or not.
rickhanlonii
force-pushed
the
rh/remove-ff-owner-stacks
branch
from
c4da3fd to
66aa6a4
Compare
rickhanlonii
force-pushed
the
rh/remove-ff-owner-stacks
branch
from
66aa6a4 to
886812d
Compare
sebmarkbage
approved these changes
Feb 24, 2025
sebmarkbage
reviewed
Feb 24, 2025
rickhanlonii
force-pushed
the
rh/remove-ff-owner-stacks
branch
from
886812d to
73596c8
Compare
rickhanlonii
force-pushed
the
rh/remove-ff-owner-stacks
branch
from
73596c8 to
5855c6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bassed off: #32425
Wait to land internally.
Commit to review.
This has landed everywhere