[ci] Try to make playground e2e tests less flaky #32582
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracting portions of #32416 for easier review. This PR dedupes @babel/types to resolve to 7.26.3, for compatibility in the root workspace where eslint-plugin-react-hooks resides. I also needed to update @babel/preset-typescript in snap. The compiler changes in HIR and ReactiveScopes were needed due to types changing. Notably, Babel [added support for optional chaining assignment](babel/babel#15751) (currently [Stage 1](https://github.com/tc39/proposal-optional-chaining-assignment)), so in the latest versions of @babel/types, AssignmentExpression.left can now also be of t.OptionalMemberExpression. Given that this is in Stage 1, the compiler probably shouldn't support this syntax, so this PR updates HIR to bailout with a TODO if there is a non LVal on the lhs of an Assignment Expression. There was also a small superficial SourceLocation change needed in `InferReactiveScopeVariables` as Babel 8 changes were [accidentally released in 7](babel/babel#10746 (comment)). It doesn't affect our analysis so it seems fine to just update with the new properties. Co-authored-by: michael faith <michaelfaith@users.noreply.github.com>
github-actions
bot
added
the
React Core Team
Not sure when this happened but the playground tests have gotten a little bit flaky. I suspect it's because of timeouts since it happens randomly so let's see if this helps.
mofeiZ
approved these changes
Mar 12, 2025
Contributor
There was a problem hiding this comment.
Thanks for trying to fix ci! I noticed that playground tests are pretty flakey as well, although runlogs I've seen show that spurious failures are due to some static fonts (e.g. fetching from localhost:3000/fonts/Optimistic_Display_W_Md.woff2 returning a 404)
- I visited Actions -> Compiler: Playground -> Action details page e.g. https://github.com/facebook/react/actions/runs/13808144588
- downloaded and unzipped runtime artifacts, then ran
yarn playwright show-trace
I've tried reproing locally but it was pretty flakey 😅
Huh actually, I just noticed that this file isn't checked into source control while other font files are.. That looks surprising
Update:
Ohh I wonder if this is related to these fonts being in the gitignore and downloaded dynamically. That could explain why I haven't seen a 404 for Source-Code-Pro-Regular.woff2
Member
Author
|
@mofeiZ I've tried that before too but I don't think it's the missing font files causing the error. If you look at the screenshots included in test-results.zip (in the CI build artifact) you'll see that the failing ones only show the header and everything else is blank |
Member
Author
|
Gonna abandon this one, doesn't seem to help |
poteto
added a commit
that referenced
this pull request
Mar 12, 2025
Extracting portions of #32416 for easier review. This PR dedupes @babel/types to resolve to 7.26.3, for compatibility in the root workspace where eslint-plugin-react-hooks resides. I also needed to update @babel/preset-typescript in snap. The compiler changes in HIR and ReactiveScopes were needed due to types changing. Notably, Babel [added support for optional chaining assignment](babel/babel#15751) (currently [Stage 1](https://github.com/tc39/proposal-optional-chaining-assignment)), so in the latest versions of @babel/types, AssignmentExpression.left can now also be of t.OptionalMemberExpression. Given that this is in Stage 1, the compiler probably shouldn't support this syntax, so this PR updates HIR to bailout with a TODO if there is a non LVal on the lhs of an Assignment Expression. There was also a small superficial SourceLocation change needed in `InferReactiveScopeVariables` as Babel 8 changes were [accidentally released in 7](babel/babel#10746 (comment)). It doesn't affect our analysis so it seems fine to just update with the new properties. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32581). * #32582 * __->__ #32581 Co-authored-by: michael faith <michaelfaith@users.noreply.github.com> Co-authored-by: michael faith <michaelfaith@users.noreply.github.com>
Contributor
|
Ahh gotcha, makes sense. Thanks for explaining! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure when this happened but the playground tests have gotten a little bit flaky. I suspect it's because of timeouts since it happens randomly so let's see if this helps.
Stack created with Sapling. Best reviewed with ReviewStack.