Skip to content

[eprh] Don't transpile to es5 #32669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 19, 2025
Merged

[eprh] Don't transpile to es5 #32669

merged 2 commits into from
Mar 19, 2025

Conversation

@poteto
Copy link
Member

@poteto poteto commented Mar 19, 2025 •
edited
Loading

Now that we've moved the sync location of the plugin, we no longer need this since those restrictions no longer apply.

Stack created with Sapling. Best reviewed with ReviewStack.

@poteto poteto mentioned this pull request Mar 19, 2025
Merged
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Mar 19, 2025
@react-sizebot
Copy link

react-sizebot commented Mar 19, 2025 •
edited
Loading

Comparing: c2a1961...64a20cb

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 517.29 kB 517.29 kB = 92.26 kB 92.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 608.06 kB 608.06 kB = 107.88 kB 107.88 kB
facebook-www/ReactDOM-prod.classic.js = 653.67 kB 653.67 kB = 115.18 kB 115.18 kB
facebook-www/ReactDOM-prod.modern.js = 643.95 kB 643.95 kB = 113.59 kB 113.59 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 2,285.29 kB 1,943.18 kB = 361.99 kB 295.00 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 2,285.08 kB 1,942.57 kB = 361.96 kB 294.94 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 2,285.08 kB 1,942.57 kB = 361.96 kB 294.94 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 2,614.31 kB 1,947.76 kB = 373.88 kB 295.92 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 2,614.12 kB 1,947.59 kB = 373.85 kB 295.89 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 2,614.12 kB 1,947.59 kB = 373.85 kB 295.89 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 2,285.29 kB 1,943.18 kB = 361.99 kB 295.00 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 2,285.08 kB 1,942.57 kB = 361.96 kB 294.94 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 2,285.08 kB 1,942.57 kB = 361.96 kB 294.94 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 2,614.31 kB 1,947.76 kB = 373.88 kB 295.92 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 2,614.12 kB 1,947.59 kB = 373.85 kB 295.89 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 2,614.12 kB 1,947.59 kB = 373.85 kB 295.89 kB

Generated by 🚫 dangerJS against 64a20cb

poteto added 2 commits March 19, 2025 11:42
@poteto
[ci] Properly format commit message
89f73e4 
Using the github variable for the commit message replaces the variable inline. If the commit message contains quotes or other characters that need to be escaped, this breaks the workflow.
@poteto
[eprh] Don't transpile to es5
64a20cb 
Now that we've moved the sync location of the plugin, we no longer need this since those restrictions no longer apply.
poteto added a commit that referenced this pull request Mar 19, 2025
@poteto
[ci] Properly format commit message (#32668)
646835f 
Using the github variable for the commit message replaces the variable
inline. If the commit message contains quotes or other characters that
need to be escaped, this breaks the workflow.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32668).
* #32669
* __->__ #32668
@poteto poteto merged commit db7dfe0 into main Mar 19, 2025
194 checks passed
@poteto poteto deleted the pr32669 branch March 19, 2025 15:49
@vercel-release-bot vercel-release-bot mentioned this pull request Mar 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@poteto @react-sizebot @facebook-github-bot