[ci] Make maintainer check always remote #32727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent local modification of the MAINTAINERS file we now always fetch from `main` instead.
github-actions
bot
added
the
React Core Team
poteto
added a commit
to reactjs/react.dev
that referenced
this pull request
Mar 24, 2025
facebook/react#32727 removes the `is_remote` param.
|
Comparing: 2d40460...760c59f Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
rickhanlonii
approved these changes
Mar 24, 2025
| @@ -30,41 +26,27 @@ jobs: | |||
| outputs: | |||
| is_core_team: ${{ steps.check_if_actor_is_maintainer.outputs.result }} | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
There was a problem hiding this comment.
@poteto have you thought about using action/checkout to checkout the main branch? It has options for selecting the repo and branch, so it could be:
steps:
- uses action/checkout@v4
- with:
ref: main
repository: facebook/reactThere was a problem hiding this comment.
I'm not sure if it's a good idea, from what I read it's not a good idea to checkout any code from something triggered via pull_request_target since it has write access to the target repo and access to secrets.
Always fetching it from main seems like the safer choice, albeit less convenient
poteto
added a commit
to reactjs/react.dev
that referenced
this pull request
Mar 24, 2025
facebook/react#32727 removes the `is_remote` param.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent local modification of the MAINTAINERS file we now always fetch from
maininstead.