Emit Preamble Contribution inline instead of the end of a boundary #32850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us write them early in the render phase.
github-actions
bot
added
the
React Core Team
gnoff
approved these changes
Apr 10, 2025
| // also clear the singleton as well. | ||
| const headPreambleContributionChunk = stringToPrecomputedChunk('<!--head-->'); | ||
| const bodyPreambleContributionChunk = stringToPrecomputedChunk('<!--body-->'); | ||
| const htmlPreambleContributionChunk = stringToPrecomputedChunk('<!--html-->'); |
Collaborator
There was a problem hiding this comment.
nit: how is this last??!? :)
Collaborator
Author
There was a problem hiding this comment.
in the order of the functions :D
github-actions bot
pushed a commit
that referenced
this pull request
Apr 10, 2025
…32850) This lets us write them early in the render phase. This should be safe because even if we write them deeply, then they still can't be wrapped by a element because then they'd no longer be in the document scope anymore. They end up flat in the body and so when we search the content we'll discover them. DiffTrain build for [8a3c5e1](8a3c5e1)
github-actions bot
pushed a commit
that referenced
this pull request
Apr 10, 2025
…32850) This lets us write them early in the render phase. This should be safe because even if we write them deeply, then they still can't be wrapped by a element because then they'd no longer be in the document scope anymore. They end up flat in the body and so when we search the content we'll discover them. DiffTrain build for [8a3c5e1](8a3c5e1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us write them early in the render phase.
This should be safe because even if we write them deeply, then they still can't be wrapped by a element because then they'd no longer be in the document scope anymore. They end up flat in the body and so when we search the content we'll discover them.