[compiler][newinference] Error handling and related fixes

compiler/packages/babel-plugin-react-compiler/src/Entrypoint/Pipeline.ts

@@ -266,8 +266,15 @@ function runWithEnvironment(
     inferMutableRanges(hir);
     log({kind: 'hir', name: 'InferMutableRanges', value: hir});
   } else {
-    inferMutationAliasingRanges(hir);
+    const mutabilityAliasingErrors = inferMutationAliasingRanges(hir, {
+      isFunctionExpression: false,
+    });
     log({kind: 'hir', name: 'InferMutationAliasingRanges', value: hir});
+    if (env.isInferredMemoEnabled) {
+      if (mutabilityAliasingErrors.isErr()) {
+        throw mutabilityAliasingErrors.unwrapErr();
+      }
+    }
   }
 
   if (env.isInferredMemoEnabled) {

compiler/packages/babel-plugin-react-compiler/src/HIR/Environment.ts

@@ -246,7 +246,7 @@ export const EnvironmentConfigSchema = z.object({
   /**
    * Enable a new model for mutability and aliasing inference
    */
-  enableNewMutationAliasingModel: z.boolean().default(false),
+  enableNewMutationAliasingModel: z.boolean().default(true),
 
   /**
    * Enables inference of optional dependency chains. Without this flag

compiler/packages/babel-plugin-react-compiler/src/HIR/ObjectShape.ts

@@ -336,6 +336,7 @@ addObject(BUILTIN_SHAPES, BuiltInArrayId, [
             kind: 'Create',
             into: signatureArgument(2),
             value: ValueKind.Primitive,
+            reason: ValueReason.KnownReturnSignature,
           },
         ],
       },
@@ -391,6 +392,7 @@ addObject(BUILTIN_SHAPES, BuiltInArrayId, [
             kind: 'Create',
             into: signatureArgument(2),
             value: ValueKind.Mutable,
+            reason: ValueReason.KnownReturnSignature,
           },
           // The first arg to the callback is an item extracted from the receiver array
           {
@@ -403,6 +405,7 @@ addObject(BUILTIN_SHAPES, BuiltInArrayId, [
             kind: 'Create',
             into: signatureArgument(5),
             value: ValueKind.Primitive,
+            reason: ValueReason.KnownReturnSignature,
           },
           // calls the callback, returning the result into a temporary
           {

compiler/packages/babel-plugin-react-compiler/src/Inference/AnalyseFunctions.ts

@@ -63,7 +63,7 @@ function lowerWithMutationAliasing(fn: HIRFunction): void {
   analyseFunctions(fn);
   inferMutationAliasingEffects(fn, {isFunctionExpression: true});
   deadCodeElimination(fn);
-  inferMutationAliasingRanges(fn);
+  inferMutationAliasingRanges(fn, {isFunctionExpression: true});
   rewriteInstructionKindsBasedOnReassignment(fn);
   inferReactiveScopeVariables(fn);
   const effects = inferMutationAliasingFunctionEffects(fn);