You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
export function addObjectToProperties(
object: Object,
properties: Array<[string, string]>,
indent: number,
+ visited: WeakSet<mixed> = new WeakSet(),
): void {
+ if (visited.has(object)) {+ return;+ }+ visited.add(object);
Suggestion importance[1-10]: 6
__
Why: The cycle detection guard helps prevent infinite recursion when serializing circular objects, but the snippet is incomplete—it needs to propagate the visited set to recursive calls for full effectiveness.
Low
General
Add explicit properties array type
Annotate the properties constant with a Flow type to ensure it is inferred as Array<[string, string]> and avoid widening errors in downstream calls.
-const properties = [+const properties: Array<[string, string]> = [
[
'Aborted',
'The stream was aborted before this Component finished rendering.',
],
];
Suggestion importance[1-10]: 4
__
Why: Explicitly annotating the properties constant with a Flow type improves type safety and consistency, but it’s a minor style change with limited functional impact.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
the
React Core Team
sebmarkbage
force-pushed
the
componentprops
branch
from
Similar to how we can include a Promise resolved value we can include Component Props.
For now I left out props for Client Components for perf unless they error. I'll try it for Client Components in general in a separate PR.