Skip to content

[Flight] Don't double badge consoles that are replayed from a third party #33685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 2, 2025
Merged

[Flight] Don't double badge consoles that are replayed from a third party #33685

merged 3 commits into from
Jul 2, 2025

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Jul 2, 2025 •
edited
Loading

If a FlightClient runs inside a FlightServer like fetching from a third party and that logs, then we currently double badge them since we just add on another badge. The issue is that this might be unnecessarily noisy but we also transfer the original format of the current server into the second badge.

This extracts our own badge and then adds the environment name as structured data which lets the client decide how to format it.

Before:

Screenshot 2025-07-02 at 2 30 07 PM

After:

Screenshot 2025-07-02 at 2 32 56 PM

@sebmarkbage sebmarkbage requested review from gnoff and unstubbable July 2, 2025 15:56
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jul 2, 2025
@react-sizebot
Copy link

react-sizebot commented Jul 2, 2025 •
edited
Loading

Comparing: 73aa744...6d299be

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js +0.01% 530.50 kB 530.57 kB +0.02% 93.66 kB 93.67 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 651.61 kB 651.66 kB = 114.78 kB 114.78 kB
facebook-www/ReactDOM-prod.classic.js +0.29% 672.89 kB 674.81 kB +0.31% 118.41 kB 118.78 kB
facebook-www/ReactDOM-prod.modern.js +0.30% 663.31 kB 665.30 kB +0.36% 116.77 kB 117.19 kB
facebook-www/React-prod.modern.js +3.45% 20.04 kB 20.73 kB +2.60% 5.19 kB 5.32 kB
facebook-www/React-prod.classic.js +3.45% 20.04 kB 20.73 kB +2.60% 5.19 kB 5.32 kB
facebook-www/React-profiling.modern.js +3.38% 20.47 kB 21.16 kB +2.58% 5.27 kB 5.40 kB
facebook-www/React-profiling.classic.js +3.38% 20.47 kB 21.16 kB +2.58% 5.27 kB 5.40 kB
facebook-www/React-dev.modern.js +3.17% 52.44 kB 54.10 kB +3.01% 11.71 kB 12.06 kB
facebook-www/React-dev.classic.js +3.17% 52.44 kB 54.10 kB +3.01% 11.71 kB 12.06 kB
facebook-www/JSXDEVRuntime-dev.classic.js +3.02% 12.51 kB 12.89 kB +2.39% 3.43 kB 3.52 kB
facebook-www/JSXDEVRuntime-dev.modern.js +3.02% 12.51 kB 12.89 kB +2.39% 3.43 kB 3.52 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/React-prod.modern.js +3.45% 20.04 kB 20.73 kB +2.60% 5.19 kB 5.32 kB
facebook-www/React-prod.classic.js +3.45% 20.04 kB 20.73 kB +2.60% 5.19 kB 5.32 kB
facebook-www/React-profiling.modern.js +3.38% 20.47 kB 21.16 kB +2.58% 5.27 kB 5.40 kB
facebook-www/React-profiling.classic.js +3.38% 20.47 kB 21.16 kB +2.58% 5.27 kB 5.40 kB
facebook-www/React-dev.modern.js +3.17% 52.44 kB 54.10 kB +3.01% 11.71 kB 12.06 kB
facebook-www/React-dev.classic.js +3.17% 52.44 kB 54.10 kB +3.01% 11.71 kB 12.06 kB
facebook-www/JSXDEVRuntime-dev.classic.js +3.02% 12.51 kB 12.89 kB +2.39% 3.43 kB 3.52 kB
facebook-www/JSXDEVRuntime-dev.modern.js +3.02% 12.51 kB 12.89 kB +2.39% 3.43 kB 3.52 kB
facebook-www/ReactReconciler-dev.modern.js +0.86% 838.62 kB 845.85 kB +1.11% 129.85 kB 131.28 kB
facebook-www/ReactReconciler-dev.classic.js +0.85% 847.85 kB 855.05 kB +1.05% 131.64 kB 133.03 kB
facebook-www/ReactART-dev.modern.js +0.77% 723.46 kB 729.07 kB +0.67% 112.68 kB 113.44 kB
facebook-www/ReactART-dev.classic.js +0.76% 732.99 kB 738.56 kB +0.59% 114.52 kB 115.19 kB
test_utils/ReactAllWarnings.js +0.69% 66.57 kB 67.03 kB +0.69% 16.72 kB 16.83 kB
oss-stable-semver/react-server/cjs/react-server-flight.development.js +0.65% 123.60 kB 124.41 kB +0.73% 22.45 kB 22.61 kB
oss-stable/react-server/cjs/react-server-flight.development.js +0.65% 123.60 kB 124.41 kB +0.73% 22.45 kB 22.61 kB
facebook-www/ReactART-prod.modern.js +0.62% 374.17 kB 376.50 kB +0.64% 62.72 kB 63.12 kB
oss-experimental/react-server/cjs/react-server-flight.development.js +0.61% 131.95 kB 132.76 kB +0.81% 24.00 kB 24.19 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js +0.60% 167.65 kB 168.65 kB +0.93% 30.60 kB 30.88 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js +0.60% 167.65 kB 168.65 kB +0.93% 30.60 kB 30.88 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.development.js +0.59% 163.95 kB 164.92 kB +0.92% 30.05 kB 30.33 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.development.js +0.59% 163.95 kB 164.92 kB +0.92% 30.05 kB 30.33 kB
facebook-www/ReactART-prod.classic.js +0.59% 384.01 kB 386.28 kB +0.65% 64.33 kB 64.75 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.59% 169.31 kB 170.31 kB +1.00% 31.05 kB 31.36 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.59% 169.31 kB 170.31 kB +1.00% 31.05 kB 31.36 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.development.js +0.57% 175.28 kB 176.27 kB +0.99% 31.73 kB 32.05 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.development.js +0.57% 175.28 kB 176.27 kB +0.99% 31.73 kB 32.05 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.57% 175.46 kB 176.46 kB +0.93% 31.93 kB 32.22 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.57% 175.46 kB 176.46 kB +0.93% 31.93 kB 32.22 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.57% 175.53 kB 176.53 kB +0.93% 31.94 kB 32.24 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.57% 175.53 kB 176.53 kB +0.93% 31.94 kB 32.24 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js +0.57% 176.37 kB 177.37 kB +0.95% 32.11 kB 32.41 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.56% 171.73 kB 172.70 kB +0.86% 31.39 kB 31.66 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.56% 171.73 kB 172.70 kB +0.86% 31.39 kB 31.66 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.56% 172.27 kB 173.24 kB +0.87% 31.51 kB 31.78 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.56% 172.27 kB 173.24 kB +0.87% 31.51 kB 31.78 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.development.js +0.56% 172.32 kB 173.29 kB +0.85% 31.61 kB 31.88 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.55% 182.05 kB 183.05 kB +0.96% 32.76 kB 33.08 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.55% 182.05 kB 183.05 kB +0.96% 32.76 kB 33.08 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.54% 183.20 kB 184.20 kB +0.95% 33.04 kB 33.36 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.54% 183.20 kB 184.20 kB +0.95% 33.04 kB 33.36 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.54% 183.25 kB 184.25 kB +0.94% 33.06 kB 33.37 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.54% 183.25 kB 184.25 kB +0.94% 33.06 kB 33.37 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.54% 184.18 kB 185.18 kB +0.85% 33.45 kB 33.74 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.54% 184.25 kB 185.24 kB +0.85% 33.46 kB 33.75 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.54% 180.09 kB 181.06 kB +0.81% 32.93 kB 33.19 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.54% 180.63 kB 181.60 kB +0.81% 33.06 kB 33.33 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.52% 191.06 kB 192.06 kB +0.83% 35.23 kB 35.52 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.development.js +0.51% 197.03 kB 198.03 kB +0.83% 35.88 kB 36.18 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.49% 203.80 kB 204.80 kB +0.80% 36.99 kB 37.29 kB
facebook-www/ReactReconciler-prod.modern.js +0.49% 496.76 kB 499.19 kB +0.49% 79.31 kB 79.70 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.49% 204.95 kB 205.95 kB +0.79% 37.28 kB 37.57 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.49% 205.01 kB 206.01 kB +0.79% 37.29 kB 37.59 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js +0.47% 404.52 kB 406.42 kB +0.47% 72.55 kB 72.90 kB
facebook-www/ReactDOMServer-dev.modern.js +0.47% 406.33 kB 408.23 kB +0.48% 73.07 kB 73.42 kB
facebook-www/ReactReconciler-prod.classic.js +0.47% 506.92 kB 509.28 kB +0.49% 80.85 kB 81.24 kB
facebook-www/ReactDOMServer-dev.classic.js +0.46% 409.77 kB 411.67 kB +0.44% 73.67 kB 73.99 kB
facebook-www/ReactDOM-dev.modern.js +0.44% 1,219.95 kB 1,225.32 kB +0.41% 201.65 kB 202.47 kB
facebook-www/ReactDOM-dev.classic.js +0.43% 1,229.12 kB 1,234.47 kB +0.40% 203.43 kB 204.24 kB
facebook-www/ReactDOMTesting-dev.modern.js +0.43% 1,236.49 kB 1,241.86 kB +0.40% 205.36 kB 206.18 kB
facebook-www/ReactDOMTesting-dev.classic.js +0.43% 1,245.66 kB 1,251.00 kB +0.38% 207.10 kB 207.90 kB
facebook-www/ReactDOMServer-prod.modern.js +0.39% 251.25 kB 252.23 kB +0.45% 45.00 kB 45.20 kB
facebook-www/ReactDOMServer-prod.classic.js +0.39% 253.61 kB 254.59 kB +0.45% 45.34 kB 45.54 kB
facebook-www/ReactDOMServerStreaming-prod.modern.js +0.38% 260.33 kB 261.31 kB +0.42% 47.66 kB 47.86 kB
facebook-www/ReactDOM-prod.modern.js +0.30% 663.31 kB 665.30 kB +0.36% 116.77 kB 117.19 kB
facebook-www/ReactDOMTesting-prod.modern.js +0.29% 677.71 kB 679.70 kB +0.35% 120.42 kB 120.84 kB
facebook-www/ReactDOM-prod.classic.js +0.29% 672.89 kB 674.81 kB +0.31% 118.41 kB 118.78 kB
facebook-www/ReactDOMTesting-prod.classic.js +0.28% 687.29 kB 689.21 kB +0.29% 122.01 kB 122.37 kB
facebook-www/ReactDOM-profiling.modern.js +0.27% 735.07 kB 737.03 kB +0.31% 126.45 kB 126.85 kB
facebook-www/ReactDOM-profiling.classic.js +0.26% 743.17 kB 745.07 kB +0.30% 127.76 kB 128.14 kB

Generated by 🚫 dangerJS against 6d299be

@sebmarkbage sebmarkbage merged commit ef8b6fa into facebook:main Jul 2, 2025
241 checks passed
This was referenced Jul 3, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@unstubbable unstubbable unstubbable approved these changes

@gnoff gnoff gnoff approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sebmarkbage @react-sizebot @unstubbable @gnoff @facebook-github-bot