[devtools] fix: fallback to reading string stack trace when failed #33700
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxyq
commented
Jul 4, 2025
| typeof callSite.getEnclosingColumnNumber === 'function' | ||
| ? (callSite: any).getEnclosingColumnNumber() | ||
| : callSite.getLineNumber(); | ||
| : callSite.getColumnNumber(); |
hoxyq
force-pushed
the
devtools/fix-parsing-structured-stack-trace-for-non-v8
branch
from
f085c83 to
ea877da
Compare
hoxyq
added a commit
that referenced
this pull request
Jul 4, 2025
Same as 6.1.4, but with 2 hotfixes: * fix: check if profiling for all profiling hooks ([hoxyq](https://github.com/hoxyq) in [#33701](#33701)) * fix: fallback to reading string stack trace when failed ([hoxyq](https://github.com/hoxyq) in [#33700](#33700))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while testing with Hermes.