Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Jul 6, 2025

I don't remember if .then(async () => {...}) is safe in the first place. Right now an async callback in .then causes the IO to be dropped from Server Requests.

The included snapshot is with .then(() => {...})

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jul 6, 2025
@react-sizebot
Copy link

Comparing: 4aad5e4...411dcba

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.50 kB 530.50 kB = 93.66 kB 93.66 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 655.04 kB 655.04 kB = 115.35 kB 115.35 kB
facebook-www/ReactDOM-prod.classic.js = 675.12 kB 675.12 kB = 118.77 kB 118.77 kB
facebook-www/ReactDOM-prod.modern.js = 665.54 kB 665.54 kB = 117.13 kB 117.13 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 411dcba

@eps1lon
Copy link
Collaborator Author

eps1lon commented Jul 6, 2025

Fixed in #33713

@eps1lon eps1lon closed this Jul 6, 2025
@eps1lon eps1lon deleted the sebbie/then-async branch July 6, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants