Work around Chrome DevTools crash on performance.measure
#33997
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome DevTools' Performance tab currently crashes when you render Components named
Layout(and probably all possible trace event names). A bug is filed but it may take a while for a fix to get out.I added a zero-width space to all
performance.measureandperformance.markcalls where we just log userspace names (Components or IO). Theawait ...or hardcoded names I haven't prefixed since they currently can't collide. A zero-width space prevents Chrome from misidentifying these trace events and doesn't show up in their UI (not even when you try to copy the names).Test plan