Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Jul 25, 2025

Chrome DevTools' Performance tab currently crashes when you render Components named Layout (and probably all possible trace event names). A bug is filed but it may take a while for a fix to get out.

I added a zero-width space to all performance.measure and performance.mark calls where we just log userspace names (Components or IO). The await ... or hardcoded names I haven't prefixed since they currently can't collide. A zero-width space prevents Chrome from misidentifying these trace events and doesn't show up in their UI (not even when you try to copy the names).

Test plan

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jul 25, 2025
@eps1lon eps1lon force-pushed the sebbie/blink-user-timing-name branch 2 times, most recently from 6ec3cef to 2f015a5 Compare July 25, 2025 08:38
@eps1lon eps1lon force-pushed the sebbie/blink-user-timing-name branch from 2f015a5 to 58fa51e Compare July 25, 2025 08:42
@eps1lon eps1lon marked this pull request as ready for review July 25, 2025 10:28
@eps1lon eps1lon requested a review from hoxyq July 25, 2025 10:28
@eps1lon eps1lon merged commit 7ca2d4c into facebook:main Jul 25, 2025
242 of 244 checks passed
@eps1lon eps1lon deleted the sebbie/blink-user-timing-name branch July 25, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants