Skip to content

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Jul 28, 2025

Stacked on #34016.

This is using the same thing we already do for the performance track to provide a description of the I/O based on the content of the resolved Promise. E.g. a Response's URL.

Screenshot 2025-07-28 at 1 09 49 AM

@sebmarkbage sebmarkbage requested review from eps1lon and hoxyq July 28, 2025 05:13
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jul 28, 2025
@react-sizebot
Copy link

react-sizebot commented Jul 28, 2025

Comparing: 101b20b...8da7cdc

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.70 kB 530.70 kB = 93.70 kB 93.70 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 655.25 kB 655.25 kB = 115.40 kB 115.40 kB
facebook-www/ReactDOM-prod.classic.js = 675.13 kB 675.13 kB = 118.75 kB 118.75 kB
facebook-www/ReactDOM-prod.modern.js = 665.56 kB 665.56 kB = 117.11 kB 117.11 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 8da7cdc

That way we don't have to hydrate the Promise in the front end just to get
the description.
Both the name and description shrink with ellipsis when they're too long.
@sebmarkbage sebmarkbage merged commit 71236c9 into facebook:main Jul 28, 2025
468 of 469 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants