Fix for empty <select> elements with value #3402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an exception when value or defaultValue is set but there are no children as ReactDOMSelect tries to mark the first children as selected even if there are no children.
Member
zpao
added a commit
that referenced
this pull request
Mar 14, 2015
Fix for empty <select> elements with value
Contributor
|
@zpao It seems your prayer wasn't heard ;) But yeah, my bad, I apparently forgot to consider the empty case. |
zpao
added a commit
to zpao/react
that referenced
this pull request
Mar 16, 2015
…th-value Fix for empty <select> elements with value (cherry picked from commit 68a2f89)
zpao
added a commit
that referenced
this pull request
Mar 16, 2015
Fix for empty <select> elements with value (cherry picked from commit 68a2f89)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an exception when value or defaultValue is set but there are no
children as ReactDOMSelect tries to mark the first children as selected
even if there are no children.
Found this issue when upgraded to 0.13 from 0.12.
JSFiddle bug demo: http://jsfiddle.net/3tL0krav/