Skip to content

[eslint] Disallow use within try/catch blocks #34040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2025
Merged

[eslint] Disallow use within try/catch blocks #34040

merged 1 commit into from
Jul 29, 2025
+65 −3

Conversation

poteto
Copy link
Member

@poteto poteto commented Jul 29, 2025

Follow up to #34032. The linter now ensures that use cannot be used within try/catch.

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jul 29, 2025
@react-sizebot
Copy link

react-sizebot commented Jul 29, 2025 •
edited
Loading

Comparing: 9be531c...6e3a120

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.04 kB 530.04 kB = 93.63 kB 93.63 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 654.48 kB 654.48 kB = 115.34 kB 115.34 kB
facebook-www/ReactDOM-prod.classic.js = 674.42 kB 674.42 kB = 118.68 kB 118.68 kB
facebook-www/ReactDOM-prod.modern.js = 664.84 kB 664.84 kB = 117.02 kB 117.02 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 6e3a120

sebmarkbage
sebmarkbage approved these changes Jul 29, 2025
View reviewed changes
Copy link
Collaborator

@sebmarkbage sebmarkbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@poteto
[eslint] Disallow usage within try/catch blocks
6e3a120 
Follow up to #34032. The linter now ensures that `use` cannot be used within try/catch.
@poteto poteto changed the title [eslint] Disallow usage within try/catch blocks [eslint] Disallow use within try/catch blocks Jul 29, 2025
@poteto poteto merged commit 820af20 into main Jul 29, 2025
241 checks passed
@poteto poteto deleted the pr34039 branch July 29, 2025 16:33
github-actions bot pushed a commit that referenced this pull request Jul 29, 2025
@poteto
[eslint] Disallow use within try/catch blocks (#34040)
16f8eb9 
Follow up to #34032. The linter now ensures that `use` cannot be used
within try/catch.

DiffTrain build for [820af20](820af20)
github-actions bot pushed a commit that referenced this pull request Jul 29, 2025
@poteto
[eslint] Disallow use within try/catch blocks (#34040)
d75704d 
Follow up to #34032. The linter now ensures that `use` cannot be used
within try/catch.

DiffTrain build for [820af20](820af20)
@nextjs-bot nextjs-bot mentioned this pull request Jul 30, 2025
Merged
@austinderek austinderek mentioned this pull request Jul 30, 2025
Closed
This was referenced Oct 2, 2025
Merged
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

@josephsavona josephsavona josephsavona approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@poteto @react-sizebot @sebmarkbage @josephsavona @facebook-github-bot